unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* epg.el: epg--status-GET_LINE not working?
@ 2017-06-26  6:58 Teemu Likonen
  2017-06-26  7:30 ` Daiki Ueno
  2017-07-06 19:29 ` Neal H. Walfield
  0 siblings, 2 replies; 16+ messages in thread
From: Teemu Likonen @ 2017-06-26  6:58 UTC (permalink / raw)
  To: emacs-devel; +Cc: Daiki Ueno, Michael Olson, Neal H. Walfield

[-- Attachment #1: Type: text/plain, Size: 1758 bytes --]

I have been thinking of fixing epg.el bug #24350
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24350>.

The problem is that in tofu conflicts epg interprets GnuPG's "GET_LINE
tofu.conflict" and waits for user input on minibuffer. The user
interaction is implemented in epg--status-GET_LINE function. But as far
as I can see it can't work. I'll try explain the problem.

Gpg is called with a command-line like this:

    GPG_AGENT_INFO=/run/user/1000/gnupg/S.gpg-agent:0:1 /usr/bin/gpg
    --no-tty --status-fd 1 --yes --use-agent --command-fd 0 --output
    /tmp/epg-output983w_C --verify -- /tmp/epg-signature9839JJ -

Note that "--command-fd 0" expects interactive commands from the file
descriptor 0 (standard input). Such commands are handled by
epg--status-GET_LINE function which is triggered when "--status-fd 1"
output contains GET_LINE command. But also note the "-" at the end of
the command line. It means that the message contents is also being
received from the file descriptor 0 (standard input). Getting both the
message's contents and --command-fd's GET_LINE input from stardard input
stream doesn't work, or so it seems in my tests.

A possible fix: Remove "--command-fd 0" from gpg's options. It looks to
me that it is not really used. Then also epg--status-GET_LINE function
can be removed.

The bug report #24350 also mentions of supporting tofu conflict
resolution. If --command-fd's GET_LINE isn't an option for epg.el what
alternatives are available? Can tofu conflict be handled after the
verifying operation if we collect enough --status-fd's TOFU_STATS
information?

-- 
/// Teemu Likonen   - .-..   <https://keybase.io/tlikonen> //
// PGP: 4E10 55DC 84E9 DFF6 13D7 8557 719D 69D3 2453 9450 ///

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2017-07-10  9:06 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-26  6:58 epg.el: epg--status-GET_LINE not working? Teemu Likonen
2017-06-26  7:30 ` Daiki Ueno
2017-06-26  7:45   ` Teemu Likonen
2017-07-05  5:21   ` Teemu Likonen
2017-07-05 16:25     ` Daiki Ueno
2017-07-05 19:03       ` Teemu Likonen
2017-07-06 19:42         ` Neal H. Walfield
2017-07-05 23:03       ` Richard Stallman
2017-07-06 19:40       ` Neal H. Walfield
2017-07-06 19:37   ` Neal H. Walfield
2017-07-07  8:37     ` Daiki Ueno
2017-07-07  9:00       ` Neal H. Walfield
2017-07-10  8:31         ` Daiki Ueno
2017-07-10  9:06           ` Neal H. Walfield
2017-07-06 19:29 ` Neal H. Walfield
2017-07-06 20:05   ` Teemu Likonen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).