Re: Two issues with the new Flymake

[joaotavora@gmail.com (João Távora)]

Lele Gaifax <lele@metapensiero.it> writes:

> In a python-mode buffer I appended "def pippo(@):" at the end of the buffer,
> and quickly deleted the last three characters (that is, "@):"): the "@"
> triggered an error in the checker tool (I'm using flake8 at the moment, but I
> think that's irrelevant), and as soon as Flymake got that it emitted
>
>   error in process sentinel: flymake-error: [Flymake] Invalid region line=417 col=13
>   error in process sentinel: [Flymake] Invalid region line=417 col=13
>
> obviously because line 417 shrinked to 10 characters.
>

Thanks for explaining. I think flymake-diag-region is too alarmist in
this case, which is reasonably normal, so I demoted the handling of this
error to a warning to the *Flymake log* buffer.

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index c2349d8c7c..e13d79770e 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -342,7 +342,7 @@ flymake-diag-region
                 (let* ((beg (fallback-bol))
                        (end (fallback-eol beg)))
                   (cons beg end)))))))
-    (error (flymake-error "Invalid region line=%s col=%s" line col))))
+    (error (flymake-log :warning "Invalid region line=%s col=%s" line col))))
 
 (defvar flymake-diagnostic-functions nil
   "Special hook of Flymake backends that check a buffer.

Regarding your pending contribution for this python backend I will post
separately very soon.

João