From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: wait_reading_process_ouput hangs in certain cases (w/ patches) Date: Tue, 13 Mar 2018 16:46:11 +0100 Message-ID: <87muzcasho.fsf@gmail.com> References: <709614e8-1937-07c1-f554-b453ed4f3d4a@binary-island.eu> <7550438b-9fd4-d374-e571-8bb16456cad5@cs.ucla.edu> <797d0e16-1bae-50c2-35f8-05489ffce935@binary-island.eu> <83tvugdiu5.fsf@gnu.org> <877er5s0xv.fsf@gmail.com> <4e4c72bb-295d-81e1-e4ed-cad256bca83c@binary-island.eu> <87zi3v9461.fsf@gmail.com> <87k1uy8x68.fsf@gmail.com> <6d1970af-8c5c-20ba-be09-0b9aa757d663@binary-island.eu> <13b3e003-d12b-33a7-3ebe-c07b017a7cc0@binary-island.eu> <87r2oow3uc.fsf@gmail.com> <2ab717c8-8d4f-ff34-04db-63b1c8b83dd4@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1520956412 26238 195.159.176.226 (13 Mar 2018 15:53:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Mar 2018 15:53:32 +0000 (UTC) Cc: Paul Eggert , Matthias Dahl , emacs-devel@gnu.org, =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?= , Lars Ingebrigtsen , Eli Zaretskii To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 13 16:53:28 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1evmEw-0006go-AM for ged-emacs-devel@m.gmane.org; Tue, 13 Mar 2018 16:53:26 +0100 Original-Received: from localhost ([::1]:40710 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evmGz-0007W7-11 for ged-emacs-devel@m.gmane.org; Tue, 13 Mar 2018 11:55:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evm83-0007n3-95 for emacs-devel@gnu.org; Tue, 13 Mar 2018 11:46:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evm82-0004JH-HT for emacs-devel@gnu.org; Tue, 13 Mar 2018 11:46:19 -0400 Original-Received: from mail-wr0-x22a.google.com ([2a00:1450:400c:c0c::22a]:41597) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evm7y-0004Ft-RU; Tue, 13 Mar 2018 11:46:14 -0400 Original-Received: by mail-wr0-x22a.google.com with SMTP id f14so133421wre.8; Tue, 13 Mar 2018 08:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=Pl4pyL8YwyTCGguYS0T3saN0pKUvuta4dAG4je2Oet0=; b=UCO0h2vXsLiA+eZQFbBXoo2L+dKtDfNYY/34YkuKfwDxlGpo8Qs5ROWQNbvOfbLyg+ lDjkN/AmM/m5fzqem0h/7wnenSL4IEE9Bb3NnzZpmvRkb5+rXhWvZen0mnqhHu58TXfM I5DQDefsVybN2KHofYDvnjSeUcyL7dd+xIRcAumSPmnRVDRr3VIY6lmYPYY0eZIE/Aeh Uesesg0qBvdqZKqml7fM/GAKrRSbjmLulNIxNH+JUDQVtyoaSX6az3p0+zdQp3p9Tx4V jHxDSiyMxBAS6t1+HzukTPjehWgVH8QRzAwqg8ChMCU4oT7ZUhVNAFxKht5HxmCFI9I1 i1PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version; bh=Pl4pyL8YwyTCGguYS0T3saN0pKUvuta4dAG4je2Oet0=; b=hScjwolEfXxoPN5lELS6PUkUeLpbKTMbldiFG/VVjth+tmawmHd6+88F9ncVq1wnAk BojoCvdbvimn9wky7WjycqKp03qlW4LvMzMXilLPy6kB8sC996qKdPHEsZWXRxjKbKDT J82Fb0PUF29Ue2qwOKIC2GdEh8NBTDCBeGV8Lyz/UNh7IBYUwQ7LdIlOmquB25+qgB0e pLyc3G4bM+5d9LBOYczvSOyoqr+xiARKr+ikjhSJxmsaI/WbkykCK31XHPAT+p9pyt8Z 7EBJO7T10JTEekjLRkr/QcC8gKh/Uy1uEeMcAb2Ad2dT6/Tpjs+MOIbWP3meYH1GpHYR M/CA== X-Gm-Message-State: AElRT7HckxTp/1Ht2yHNlrt5Rgn7e/rdESvnSaKX9a1mrRpT/0RY6WYm X5FJZCsQWDJPlzZdlTsxXpNdZdv1BtM= X-Google-Smtp-Source: AG47ELsz7aZ4oolvOn6m8DYeRG4gijmNbAOsmvUicDGo4Cpk9SbaZC4DHFlTDp7SyNXYOFoBQhn8yQ== X-Received: by 10.223.184.234 with SMTP id c39mr978918wrg.67.1520955973339; Tue, 13 Mar 2018 08:46:13 -0700 (PDT) Original-Received: from rpluim-ubuntu ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id u22sm605101wrf.86.2018.03.13.08.46.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Mar 2018 08:46:12 -0700 (PDT) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <2ab717c8-8d4f-ff34-04db-63b1c8b83dd4@yandex.ru> (Dmitry Gutov's message of "Tue, 13 Mar 2018 17:36:31 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223692 Archived-At: Dmitry Gutov writes: > Hi Matthias, > > On 3/13/18 5:10 PM, Matthias Dahl wrote: >> Hi Robert, >> >> Thank you very much for pointing this out. You are absolutely correct, >> my patches did undo your fix. > > This kind of accident seems pretty bad. It got caught before it got committed, so not that bad. > Is there any chance to write a > regression test? Ideally both for Robert's and your fixes. > > Fiddly, hard-to-reproduce misbehavior is the ideal target for > regression tests, IMO. My current test-case for 21337 is 'visit a bunch of files, make sure global-auto-revert is turned on and auto-revert-use-notify is t, run Gnus (or anything else that makes TLS connections), wait for errors to be signalled by inotify'. I don't know how to write a regression test for that. Robert