From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Thu, 09 Aug 2018 13:29:31 -0600 Message-ID: <87mutv72zo.fsf@tromey.com> References: <87o9fbbw1t.fsf@tromey.com> <87h8k3ik1h.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533842914 3695 195.159.176.226 (9 Aug 2018 19:28:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 9 Aug 2018 19:28:34 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 09 21:28:30 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnqbk-0000pi-MS for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2018 21:28:28 +0200 Original-Received: from localhost ([::1]:52520 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnqdr-00036B-8y for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2018 15:30:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnqcr-00034W-0k for emacs-devel@gnu.org; Thu, 09 Aug 2018 15:29:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnqcn-0001oQ-SZ for emacs-devel@gnu.org; Thu, 09 Aug 2018 15:29:37 -0400 Original-Received: from gateway32.websitewelcome.com ([192.185.145.123]:32729) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fnqcn-0001mM-KE for emacs-devel@gnu.org; Thu, 09 Aug 2018 15:29:33 -0400 Original-Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 73ED62659B for ; Thu, 9 Aug 2018 14:29:32 -0500 (CDT) Original-Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id nqcmfcI5j79N3nqcmfuQT7; Thu, 09 Aug 2018 14:29:32 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7tvhM55UwRYqPs/e/ZBdDQFrVLnVteLNM4CHSykpth4=; b=sQPnNVlBfkWzq1gvRtiVYCYhC2 7YyObDoW7rl/ee1RfrYQ5FW51443aGmvK/4MOOemvql3EcGU+dSi0574f7V7H9HBDK7eqXOwzHgzo gIiOfubnWlJmKdJnMMQrmEwrg; Original-Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:34794 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fnqcm-002QqF-60; Thu, 09 Aug 2018 14:29:32 -0500 X-Attribution: Tom In-Reply-To: (Andy Moreton's message of "Thu, 09 Aug 2018 18:08:14 +0100") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.85.72 X-Source-L: No X-Exim-ID: 1fnqcm-002QqF-60 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-85-72.hlrn.qwest.net (pokyo) [75.166.85.72]:34794 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 192.185.145.123 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228343 Archived-At: >>>>> "Andy" == Andy Moreton writes: Andy> On Thu 09 Aug 2018, Tom Tromey wrote: >>>>>>> "Andy" == Andy Moreton writes: >> Andy> It appears that mini-gmp does not define GMP_NUMB_BITS, so does this Andy> patch work for you instead ? >> >> Let me know if you want me to push this to the branch for you. Andy> Yes please. Andy> As a minor speedup, you could also change various places that use Andy> "mpz_cmp_si (foo, 0) >= 0" to use "mpz_sgn (foo) >= 0". I've pushed your patch and the one you suggested here. I re-ran the test suite first. Thanks for all your help on this project. Tom