unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* thread-alive-p ?  Why not thread-live-p?
@ 2018-08-29 22:12 Live System User
  2018-08-30  2:26 ` Stefan Monnier
  2018-08-30  2:28 ` Tom Tromey
  0 siblings, 2 replies; 9+ messages in thread
From: Live System User @ 2018-08-29 22:12 UTC (permalink / raw)
  To: emacs-devel

Hi,

        Admittedly a minor nit, but why use the name `thread-alive-p'
        instead of `thread-live-p' in the
        scratch/list-thread branch?

        This would make it similiar to `process-live-p',
        `buffer-live-p', `window-live-p' etc for threead
        objects.

        Thanks.




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: thread-alive-p ?  Why not thread-live-p?
  2018-08-29 22:12 thread-alive-p ? Why not thread-live-p? Live System User
@ 2018-08-30  2:26 ` Stefan Monnier
  2018-08-30  2:28 ` Tom Tromey
  1 sibling, 0 replies; 9+ messages in thread
From: Stefan Monnier @ 2018-08-30  2:26 UTC (permalink / raw)
  To: emacs-devel

>         Admittedly a minor nit, but why use the name `thread-alive-p'
>         instead of `thread-live-p' in the
>         scratch/list-thread branch?

To keep the coder on their toes,


        Stefan




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: thread-alive-p ?  Why not thread-live-p?
  2018-08-29 22:12 thread-alive-p ? Why not thread-live-p? Live System User
  2018-08-30  2:26 ` Stefan Monnier
@ 2018-08-30  2:28 ` Tom Tromey
  2018-08-30  5:52   ` John Wiegley
  1 sibling, 1 reply; 9+ messages in thread
From: Tom Tromey @ 2018-08-30  2:28 UTC (permalink / raw)
  To: Live System User; +Cc: emacs-devel

>>>>> ">" == Live System User <nyc4bos@aol.com> writes:

>>         Admittedly a minor nit, but why use the name `thread-alive-p'
>>         instead of `thread-live-p' in the
>>         scratch/list-thread branch?

Just thoughtlessness on my part, back when.

>>         This would make it similiar to `process-live-p',
>>         `buffer-live-p', `window-live-p' etc for threead
>>         objects.

There are a few *-alive-p functions as well.  I think if I had thought
of it I would have chosen thread-live-p though.

I tend to doubt it is worth switching, but I wouldn't oppose it.

Tom



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: thread-alive-p ?  Why not thread-live-p?
  2018-08-30  2:28 ` Tom Tromey
@ 2018-08-30  5:52   ` John Wiegley
  2018-08-30 10:06     ` Michael Albinus
  0 siblings, 1 reply; 9+ messages in thread
From: John Wiegley @ 2018-08-30  5:52 UTC (permalink / raw)
  To: Tom Tromey; +Cc: Live System User, emacs-devel

>>>>> "TT" == Tom Tromey <tom@tromey.com> writes:

TT> There are a few *-alive-p functions as well. I think if I had thought of
TT> it I would have chosen thread-live-p though.

I do prefer live-p, but I'm not bothered-p either.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: thread-alive-p ?  Why not thread-live-p?
  2018-08-30  5:52   ` John Wiegley
@ 2018-08-30 10:06     ` Michael Albinus
  2018-08-30 13:26       ` Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: Michael Albinus @ 2018-08-30 10:06 UTC (permalink / raw)
  To: Live System User, emacs-devel

"John Wiegley" <johnw@gnu.org> writes:

>>>>>> "TT" == Tom Tromey <tom@tromey.com> writes:
>
> TT> There are a few *-alive-p functions as well. I think if I had thought of
> TT> it I would have chosen thread-live-p though.

--8<---------------cut here---------------start------------->8---
(let ((completion-regexp-list '("-alive-p$"))) (all-completions "" obarray))
=> ("gnus-alive-p" "thread-alive-p" "mm-keep-viewer-alive-p")

(let ((completion-regexp-list '("-live-p$"))) (all-completions "" obarray))
=> ("process-live-p" "window-live-p" "ediff-buffer-live-p" "gnus-buffer-live-p" "erc-server-buffer-live-p" "frame-live-p" "buffer-live-p" "dframe-live-p" "terminal-live-p")
--8<---------------cut here---------------end--------------->8---

> I do prefer live-p, but I'm not bothered-p either.

If nobody objects next days, I'll change the name. It's not too late, I
believe.

Best regards, Michael.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: thread-alive-p ?  Why not thread-live-p?
  2018-08-30 10:06     ` Michael Albinus
@ 2018-08-30 13:26       ` Eli Zaretskii
  2018-08-30 13:37         ` Michael Albinus
  0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2018-08-30 13:26 UTC (permalink / raw)
  To: Michael Albinus; +Cc: nyc4bos, emacs-devel

> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Thu, 30 Aug 2018 12:06:02 +0200
> 
> > I do prefer live-p, but I'm not bothered-p either.
> 
> If nobody objects next days, I'll change the name. It's not too late, I
> believe.

It's fine with me to rename, but since we already released Emacs 26.1
with this API, we will need to leave behind an obsolete alias.

Thanks.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: thread-alive-p ?  Why not thread-live-p?
  2018-08-30 13:26       ` Eli Zaretskii
@ 2018-08-30 13:37         ` Michael Albinus
  2018-08-30 13:52           ` Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: Michael Albinus @ 2018-08-30 13:37 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: nyc4bos, emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

>> > I do prefer live-p, but I'm not bothered-p either.
>> 
>> If nobody objects next days, I'll change the name. It's not too late, I
>> believe.
>
> It's fine with me to rename, but since we already released Emacs 26.1
> with this API, we will need to leave behind an obsolete alias.

Will do. For the emacs-26 branch, or master? I'd prefer the former, in
order not to see too much code in the wild with the obsolete name.

> Thanks.

Best regards, Michael.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: thread-alive-p ?  Why not thread-live-p?
  2018-08-30 13:37         ` Michael Albinus
@ 2018-08-30 13:52           ` Eli Zaretskii
  2018-08-31  9:58             ` Michael Albinus
  0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2018-08-30 13:52 UTC (permalink / raw)
  To: Michael Albinus; +Cc: nyc4bos, emacs-devel

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: nyc4bos@aol.com,  emacs-devel@gnu.org
> Date: Thu, 30 Aug 2018 15:37:14 +0200
> 
> > It's fine with me to rename, but since we already released Emacs 26.1
> > with this API, we will need to leave behind an obsolete alias.
> 
> Will do. For the emacs-26 branch, or master? I'd prefer the former, in
> order not to see too much code in the wild with the obsolete name.

It could go to emacs-26, but there we should not announce
thread-alive-p obsolete yet, it should be obsoleted on master, I
think.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: thread-alive-p ?  Why not thread-live-p?
  2018-08-30 13:52           ` Eli Zaretskii
@ 2018-08-31  9:58             ` Michael Albinus
  0 siblings, 0 replies; 9+ messages in thread
From: Michael Albinus @ 2018-08-31  9:58 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: nyc4bos, emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> It could go to emacs-26, but there we should not announce
> thread-alive-p obsolete yet, it should be obsoleted on master, I
> think.

Done.

Best regards, Michael.



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-08-31  9:58 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-29 22:12 thread-alive-p ? Why not thread-live-p? Live System User
2018-08-30  2:26 ` Stefan Monnier
2018-08-30  2:28 ` Tom Tromey
2018-08-30  5:52   ` John Wiegley
2018-08-30 10:06     ` Michael Albinus
2018-08-30 13:26       ` Eli Zaretskii
2018-08-30 13:37         ` Michael Albinus
2018-08-30 13:52           ` Eli Zaretskii
2018-08-31  9:58             ` Michael Albinus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).