From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Garreau\, Alexandre" Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Thu, 01 Nov 2018 00:33:39 +0100 Message-ID: <87muqtr8rw.fsf@portable.galex-713.eu> References: <20151216202605.GA3752@acm.fritz.box> <87egdy8tyz.fsf@fencepost.gnu.org> <56895FDE.4060406@yandex.ru> <8760za8r4a.fsf@fencepost.gnu.org> <87h9iunkcg.fsf@web.de> <87h8hc4xw2.fsf_-_@web.de> <83tvlcsnee.fsf@gnu.org> <87pnw037ar.fsf@web.de> <83ftwvs7y9.fsf@gnu.org> <877ei7mkfh.fsf@web.de> <87a7mze7tl.fsf@web.de> <831s89mo03.fsf@gnu.org> <87pnvsifxt.fsf@web.de> <83muqwkkt1.fsf@gnu.org> <875zxjv3ku.fsf@web.de> <83o9bbjqcj.fsf@gnu.org> <87r2g7t7bo.fsf@web.de> <83tvl2hzt6.fsf@gnu.org> <87r2g5x3gk.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1541028742 13964 195.159.176.226 (31 Oct 2018 23:32:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 31 Oct 2018 23:32:22 +0000 (UTC) User-Agent: Gnus (5.13), GNU Emacs 25.1.1 (i686-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-09-15, modified by Debian Cc: Eli Zaretskii , monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 01 00:32:18 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHzyE-0003VD-3s for ged-emacs-devel@m.gmane.org; Thu, 01 Nov 2018 00:32:18 +0100 Original-Received: from localhost ([::1]:34024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gI00K-00067u-4n for ged-emacs-devel@m.gmane.org; Wed, 31 Oct 2018 19:34:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHzzd-00067e-1H for emacs-devel@gnu.org; Wed, 31 Oct 2018 19:33:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHzzb-0001DF-Tm for emacs-devel@gnu.org; Wed, 31 Oct 2018 19:33:44 -0400 Original-Received: from portable.galex-713.eu ([2a00:5884:8305::1]:46052) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gHzzb-0001CP-GL; Wed, 31 Oct 2018 19:33:43 -0400 Original-Received: from localhost ([::1] helo=portable.galex-713.eu) by portable.galex-713.eu with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gHzzX-0003qK-IE; Thu, 01 Nov 2018 00:33:39 +0100 PGP-FINGERPRINT: E109 9988 4197 D7CB B0BC 5C23 8DEB 24BA 867D 3F7F Accept-Language: fr, en, eo, it, br In-Reply-To: <87r2g5x3gk.fsf@web.de> (Michael Heerdegen's message of "Wed, 31 Oct 2018 21:31:55 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:5884:8305::1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230925 Archived-At: On 2018-10-31 at 15:37, Stefan Monnier wrote: >> Really? Can you show a few examples? Maybe there's something wrong >> with our documentation if people make such mistakes. > > I don't think calling them mistakes is right. It might just be > a stylistic preference on the part of the author, [=E2=80=A6] On 2018-10-31 at 21:31, Michael Heerdegen wrote: > Eli Zaretskii writes: >> > BTW, while preparing the first patch I already found tons of >> > unnecessary quotes outside of pcase patterns: quotes quoting >> > self-evaluating objects like strings and numbers. >> >> Really? Can you show a few examples? Maybe there's something wrong >> with our documentation if people make such mistakes. > > Here is the result of a quick search. As Stefan said, I don't say we > should fix (all of) these. But some really look strange. There are > many quoted strings - I wonder if these quotes change the behavior of > the compiler or so? I want to notice this kind of questionment is exactly the kind of reasons why such =E2=80=9Cauthor stylistic preference=E2=80=9D usage should= be avoided: because unless a such =E2=80=9Cstylistic preference=E2=80=9D, along with it= s reason, meanings, and use cases, is formally made explicit somewhere so that its meaning (and use) is clear (but then we will end with yet another non-self-quoting semantic formatting usage (just as =E2=80=9C((alist cons k= ey) . (alist cons value list))=E2=80=9D and =E2=80=9C((alist cons key) alist co= ns value list)=E2=80=9D)) then people will begin to really (hence unacknoweldgly, irrationally, and thus inconsistently) believe this may be kind of special low-level optimization wizard trick, and recopy that without understanding, so that supposed =E2=80=9Cmeaningful stylistic preference=E2= =80=9D will end up in inconsistent garbage random obfuscation everywhere (I=E2=80=99m exagerating but this is a useless risk).