unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* message.el bug: message-field-value issue with folded headers
@ 2019-07-12 12:45 Yuri D'Elia
  2019-07-12 12:48 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: Yuri D'Elia @ 2019-07-12 12:45 UTC (permalink / raw)
  To: emacs-devel; +Cc: Lars Ingebrigtsen

In a recent change in message.el the headers are folded automatically
before being sent.

If the header has no whitespace, it will essentially move the entire
value into the next line:

|Header:
| long-value

Does it make sense to do so?

Anyway, `message-fetch-field' doesn't handle this case correctly. By
substituting "\n[\t ]+" => " " we're left with a leading space:

  " long value"

Can we strip leading and trailing whitespace from value at the end of
the function?




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: message.el bug: message-field-value issue with folded headers
  2019-07-12 12:45 message.el bug: message-field-value issue with folded headers Yuri D'Elia
@ 2019-07-12 12:48 ` Lars Ingebrigtsen
  2019-07-12 14:08   ` Lars Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-12 12:48 UTC (permalink / raw)
  To: Yuri D'Elia; +Cc: emacs-devel

Yuri D'Elia <wavexx@thregr.org> writes:

> If the header has no whitespace, it will essentially move the entire
> value into the next line:
>
> |Header:
> | long-value
>
> Does it make sense to do so?

Nope; that's a bug.

> Anyway, `message-fetch-field' doesn't handle this case correctly. By
> substituting "\n[\t ]+" => " " we're left with a leading space:
>
>   " long value"

That's also a bug.  It's nice that this folding change is revealing so
many bugs.  :-)

I'll get fixing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: message.el bug: message-field-value issue with folded headers
  2019-07-12 12:48 ` Lars Ingebrigtsen
@ 2019-07-12 14:08   ` Lars Ingebrigtsen
  0 siblings, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-12 14:08 UTC (permalink / raw)
  To: Yuri D'Elia; +Cc: emacs-devel

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I'll get fixing.

Both these should now be fixed on the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-12 14:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-12 12:45 message.el bug: message-field-value issue with folded headers Yuri D'Elia
2019-07-12 12:48 ` Lars Ingebrigtsen
2019-07-12 14:08   ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).