unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jonas Bernoulli <jonas@bernoul.li>
To: dick.r.chiang@gmail.com
Cc: Phil Sainty <psainty@orcon.net.nz>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Submitting patches from magit
Date: Thu, 19 Dec 2019 23:24:30 +0100	[thread overview]
Message-ID: <87mubox8bl.fsf@bernoul.li> (raw)
In-Reply-To: <87bls459pl.fsf@dick>


dick.r.chiang@gmail.com writes:

>> Assuming this is only useful with Magit installed, would it make more sense
>> for it to be contributed to Magit?
>
> Maybe.  The package monkeys a magit menu to seamlessly insert itself, so
> embedding within magit would actually *reduce* the lines of code.

Instead of the magit-patch-changelog-initialize hack use:

  (transient-append-suffix 'magit-patch-create "c"
    '("e" "Create patches for Emacs" magit-patch-changelog-create))

Also don't fiddle with after-init-hook.  Just put this at the top-level.

> But I suspect Mr. Bernoulli would not want such an emacs-devel-specific task
> to be integrated into a fully general git porcelain.

Yes, I think this should remain a separate package.



      reply	other threads:[~2019-12-19 22:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 19:49 Submitting patches from magit dick.r.chiang
2019-12-19 20:06 ` Jonas Bernoulli
2019-12-19 20:25   ` Jonas Bernoulli
2019-12-19 20:11 ` Óscar Fuentes
2019-12-20 18:29   ` dick.r.chiang
2019-12-20 19:18     ` Óscar Fuentes
2019-12-20 19:51       ` dick.r.chiang
2019-12-20 21:26       ` Alan Third
2019-12-19 20:29 ` Phil Sainty
2019-12-19 20:41   ` dick.r.chiang
2019-12-19 22:24     ` Jonas Bernoulli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mubox8bl.fsf@bernoul.li \
    --to=jonas@bernoul.li \
    --cc=dick.r.chiang@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=psainty@orcon.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).