unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: ndame <emacsuser@freemail.hu>,
	"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: Intelligent stacking of messages in the echo area
Date: Tue, 24 Dec 2019 17:40:18 +0800	[thread overview]
Message-ID: <87mubidptp.fsf@localhost> (raw)
In-Reply-To: <87pngepti3.fsf@mail.linkov.net>

I was testing the code for a while.
There seem to be one irritating (for me) problem with the way
set-message-function is implemented.
When I run a command changing current buffer and emitting multiple
messages, emacs frame is redrawn every time a new message comes out.
Specifically, I was running org-capture, which changes windows
configuration, switches to different buffer, and emits multiple messages
while running. Normally, it runs very fast (the capture template I used
does not require any user input), but with multi-message, I can see the
frame being redrawn on every new message popping up. Since window
configuration is different, full redraw is forced and the whole
org-capture runs a lot slower.

Best,
Ihor



Juri Linkov <juri@linkov.net> writes:

>> A slightly improved version of the code, which prevents stacking
>> potentially "spammy" messages (like from eldoc or
>> org-display-outline-path). The messages are detected by looking at
>> messages-log-max variable, which is typically set to nil by such
>> functions.
>
> Good heuristics.  Another heuristics that could be added is
> to filter out transient messages ending with ellipsis -
> added here to a new variable like Eli asked to do:
>
>
> (defcustom multi-message-timeout 2
>   "Number of seconds between messages before clearing the accumulated list."
>   :type 'number
>   :group 'minibuffer
>   :version "28.1")
>
> (defcustom multi-message-max 8
>   "Max size of the list of accumulated messages."
>   :type 'number
>   :group 'minibuffer
>   :version "28.1")
>
> (defcustom multi-message-transient "\\.\\.\\.\\'"
>   "Regexp to filter out transient messages that should not be stacked."
>   :type 'regexp
>   :group 'minibuffer
>   :version "28.1")
>
> (defvar multi-message-separator "\n")
>
> (defvar multi-message-list nil)
>
> (defun set-multi-message (message)
>   "Return recent messages as one string to display in the echo area.
> Note that this feature works best only when `resize-mini-windows'
> is at its default value `grow-only'."
>   (let ((last-message (car multi-message-list)))
>     (unless (and last-message (equal message (aref last-message 1)))
>       (when last-message
>         (cond
>          ((> (float-time) (+ (aref last-message 0) multi-message-timeout))
>           (setq multi-message-list nil))
>          ((or
>            ;; `message-log-max' was nil, potential clutter.
>            (aref last-message 2)
>            (string-match-p multi-message-transient (aref last-message 1)))
>           (setq multi-message-list (cdr multi-message-list)))))
>       (push (vector (float-time) message (not message-log-max)) multi-message-list)
>       (when (> (length multi-message-list) multi-message-max)
>         (setf (nthcdr multi-message-max multi-message-list) nil)))
>     (mapconcat (lambda (m) (aref m 1))
>                (reverse multi-message-list)
>                multi-message-separator)))
>
> (setq set-message-function 'set-multi-message)

-- 
Ihor Radchenko,
PhD,
Center for Advancing Materials Performance from the Nanoscale (CAMP-nano)
State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong University, Xi'an, China
Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg



  reply	other threads:[~2019-12-24  9:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-31  5:35 Intelligent stacking of messages in the echo area ndame
2019-08-31  9:46 ` Marcin Borkowski
2019-12-21 22:07 ` Juri Linkov
2019-12-22  3:30   ` Eli Zaretskii
2019-12-23  2:59   ` Richard Stallman
2019-12-23 22:46     ` Juri Linkov
2019-12-23  3:50   ` Ihor Radchenko
2019-12-23 13:38     ` Eli Zaretskii
2019-12-24  9:24       ` Ihor Radchenko
2019-12-24 15:36         ` Eli Zaretskii
2019-12-25  4:21           ` Ihor Radchenko
2019-12-23 22:47     ` Juri Linkov
2019-12-24  9:40       ` Ihor Radchenko [this message]
2019-12-24 15:43         ` Eli Zaretskii
2019-12-24 17:32           ` Ihor Radchenko
2019-12-25  0:15         ` Juri Linkov
2019-12-25  5:35           ` Ihor Radchenko
2020-01-29 22:54             ` Juri Linkov
2020-01-24 10:14       ` Eric S Fraga
2020-01-28 22:34         ` Juri Linkov
2020-01-29 22:41           ` Juri Linkov
2020-01-29 23:53             ` Stefan Monnier
2020-01-30 22:35               ` Juri Linkov
2020-01-30 23:07                 ` Stefan Monnier
  -- strict thread matches above, loose matches on Subject: below --
2022-04-09  4:46 emacsq
2022-04-09 18:53 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mubidptp.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=emacsuser@freemail.hu \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).