From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: RFC: Automatic setup for bug-reference-mode Date: Thu, 18 Jun 2020 08:06:37 +0200 Message-ID: <87mu50c3gy.fsf@gnu.org> References: <87r1uihtsu.fsf@gnu.org> <87h7vd3cbs.fsf@gnu.org> <87tuzdsj8d.fsf@gnu.org> <87tuzd755z.fsf@gnu.org> <86o8pkabzh.fsf@stephe-leake.org> <87pna0mxxw.fsf@gnu.org> <87ftatcr48.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="104590"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stephen Leake , emacs-devel To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 18 08:07:29 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlnhx-000R7H-5Y for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Jun 2020 08:07:29 +0200 Original-Received: from localhost ([::1]:35006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlnhw-0004Rt-5C for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Jun 2020 02:07:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlnhI-0003Ta-82 for emacs-devel@gnu.org; Thu, 18 Jun 2020 02:06:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35054) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlnhG-00029G-Aq; Thu, 18 Jun 2020 02:06:46 -0400 Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:53195) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1jlnhD-0005Ut-DW; Thu, 18 Jun 2020 02:06:45 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 0769227C0054; Thu, 18 Jun 2020 02:06:43 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 18 Jun 2020 02:06:43 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejfedguddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufhffjgfkfgggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe dtleeiffekueffudeufeefhfeitdejuedtueevgeffgfdtjeelkeehgeekteekveenucfk phepleefrddvfeeirddufeehrdeljeenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehthhhorhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgr lhhithihqdekieejfeekjeekgedqieefhedvleekqdhtshguhheppehgnhhurdhorhhgse hfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: from thinkpad-t440p (p5dec8761.dip0.t-ipconnect.de [93.236.135.97]) by mail.messagingengine.com (Postfix) with ESMTPA id 5E02A3060FE7; Thu, 18 Jun 2020 02:06:41 -0400 (EDT) Mail-Followup-To: Juri Linkov , Stephen Leake , emacs-devel In-Reply-To: <87ftatcr48.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 18 Jun 2020 00:35:51 +0300") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252303 Archived-At: Hi chaps, >> Typing 'C-x v d' (vc-dir) on a repository without 'origin' >> raises the error "Failed (status 128): git --no-pager remote get-url ." > > Also noticed that (when the current branch has no default remote). > Just fixed in master. Ah, sorry, haven't seen your fix. But I think it may still have been wrong. I think the actual problem was that git config branch..remote wasn't necessarily called in the given project DIR so returned the global default remote "origin". So I now bind default-directory to the given DIR. I'm not exactly sure if that is really needed but at least it was needed for M-: (vc-git-dir-extra-headers "~/some/project/") which I used to reproduce the problem (which still occurred). Maybe it's not needed when vc-dir calls it, but let's say it is a good change anyway since it makes the function debuggable standalone. Thanks, Tassilo