From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] tab-line-alternate-colors Date: Sun, 13 Dec 2020 10:45:00 +0200 Organization: LINKOV.NET Message-ID: <87mtyiqfzv.fsf@mail.linkov.net> References: <87360autpy.fsf@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28415"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 13 09:52:37 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koN7N-0007Id-B7 for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Dec 2020 09:52:37 +0100 Original-Received: from localhost ([::1]:44090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koN7M-000794-Df for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Dec 2020 03:52:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koN6E-0006Lk-Ka for emacs-devel@gnu.org; Sun, 13 Dec 2020 03:51:26 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:49907) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koN6B-0001lM-2o for emacs-devel@gnu.org; Sun, 13 Dec 2020 03:51:26 -0500 X-Originating-IP: 91.129.99.98 Original-Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 3ADF4FF804; Sun, 13 Dec 2020 08:51:17 +0000 (UTC) In-Reply-To: <87360autpy.fsf@alphapapa.net> (Adam Porter's message of "Sun, 13 Dec 2020 00:04:57 -0600") Received-SPF: pass client-ip=217.70.183.199; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260753 Archived-At: > This patch adds a new option and face which makes inactive tab-line tabs > display in alternating colors, which makes them easier to distinguish > between. Assuming that the idea is acceptable, please let me know if any > further changes to the patch are required. Thanks, it would be nice to support displaying tabs in alternating colors. But there are endless possibilities for look and feel of tabs, so instead of hard-coding only one of them for alternating colors, I suggest to add a customizable function with a name like 'tab-line-tab-face' that with a tab provided as its arg (and a list of tabs to be able to find the ordinal number of the given tab) would return its face to use.