From: Philip Kaludercic <philipk@posteo.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [ELPA] A Setup package
Date: Sat, 13 Mar 2021 20:44:28 +0100 [thread overview]
Message-ID: <87mtv6j0tf.fsf@posteo.net> (raw)
In-Reply-To: <jwvy2eq7u6o.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 13 Mar 2021 14:14:34 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I think all the issues should now be resolved. I just pushed a commit
>> adding edebug support. setup-help was moved into setup's docstring, a
>> lot of the macros were redefined to look more like setq, and all macros
>> were redefined to use keywords (for now).
>
> [ I have some further suggestions for the code, but they'll come later. ]
>
> I was about to add it to GNU ELPA, but I noticed two problems:
>
> 1- The file is missing a copyright notice and it is using the CC0 license.
> See the patch below to fix those issues (the copyright part reflects
> the fact that you consider the package as being covered by your
> copyright assignment and the license change is because we want to
> distribute all GNU ELPA packages under the GPLv3 license; you're of
> course perfectly free to also distribute this package under any other
> license you want, but we want to use the GPLv3 for the copy we
> distribute).
Done.
> 2- AFAIK you rebased (or force-pushed or something like that) your
> branch, which makes it painful for any"one" tracking your branch, such
> as elpa.git. In order for the elpa.git branch tracking your
> SourceHut repository to work sanely it'll be important not to rebase
> (or force-push...) in the future.
I actually created a new repository, because it seemed cleaner compared
to pushing all the changes as commits. But I will keep this in mind for
the future.
--
Philip K.
next prev parent reply other threads:[~2021-03-13 19:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 11:43 [ELPA] A Setup package Philip K.
2021-02-04 11:47 ` Philip K.
2021-02-09 21:56 ` Stefan Monnier
2021-02-09 23:42 ` Philip K.
2021-03-11 16:17 ` Philip Kaludercic
2021-03-13 19:14 ` Stefan Monnier
2021-03-13 19:44 ` Philip Kaludercic [this message]
2021-03-14 15:07 ` Stefan Monnier
2021-03-14 16:21 ` Philip Kaludercic
2021-03-14 20:19 ` Stefan Monnier
2021-03-14 23:39 ` Philip Kaludercic
2021-03-15 4:15 ` Stefan Monnier
2021-03-15 10:09 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtv6j0tf.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).