From: Juri Linkov <juri@linkov.net>
To: Zhiwei Chen <chenzhiwei03@kuaishou.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Repeat lambda
Date: Mon, 29 Mar 2021 22:28:43 +0300 [thread overview]
Message-ID: <87mtul7tcs.fsf@mail.linkov.net> (raw)
In-Reply-To: <8FE23CF4-90D9-4633-9CCF-B1FDD24DABCE@kuaishou.com> (Zhiwei Chen's message of "Fri, 26 Mar 2021 06:00:23 +0000")
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
>> diff --git a/lisp/repeat.el b/lisp/repeat.el
>> index 84a613da0c..4be4f766ef 100644
>> --- a/lisp/repeat.el
>> +++ b/lisp/repeat.el
>> @@ -398,7 +398,7 @@ repeat-post-hook
>> (when repeat-exit-key
>> (define-key map repeat-exit-key 'ignore))
>> - (set-transient-map map)))))))
>> + (set-transient-map map t)))))))
>
> So there is no help message “[Repeat with o, O, ...]” displayed when use 'C-x o O’.
Also I noticed another problem with using `t' for KEEP-PRED in set-transient-map:
it doesn't handle `repeat-exit-key' after every command. So `t' can't be used.
> Maybe we can wrap all commands in `repeat-map’ and show the help
> message first, then invoke the bound function?
The problem is that currently we get `repeat-map' only from command symbol:
(get this-command 'repeat-map)
But maybe we could allow the command to set its next repeat-map explicitly:
(define-key map "O" (lambda ()
(interactive)
(setq repeat-map 'other-window-repeat-map)
(other-window -1)))
with such patch:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: repeat-map.patch --]
[-- Type: text/x-diff, Size: 1130 bytes --]
diff --git a/lisp/repeat.el b/lisp/repeat.el
index a2b04b81b0..5ae2ec2967 100644
--- a/lisp/repeat.el
+++ b/lisp/repeat.el
@@ -342,6 +342,8 @@ repeat-exit-key
:group 'convenience
:version "28.1")
+;;;###autoload (defvar repeat-map nil)
+
;;;###autoload
(define-minor-mode repeat-mode
"Toggle Repeat mode.
@@ -364,8 +366,9 @@ repeat-mode
(defun repeat-post-hook ()
"Function run after commands to set transient keymap for repeatable keys."
(when repeat-mode
- (let ((repeat-map (and (symbolp this-command)
- (get this-command 'repeat-map))))
+ (let ((repeat-map (or (and (symbolp this-command)
+ (get this-command 'repeat-map))
+ repeat-map)))
(when repeat-map
(when (boundp repeat-map)
(setq repeat-map (symbol-value repeat-map)))
@@ -398,7 +401,8 @@ repeat-post-hook
(when repeat-exit-key
(define-key map repeat-exit-key 'ignore))
- (set-transient-map map)))))))
+ (set-transient-map map))))))
+ (setq repeat-map nil))
(provide 'repeat)
next prev parent reply other threads:[~2021-03-29 19:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-14 22:51 Some minor suggestions to Tab Bar Gabriel
2021-03-15 9:24 ` Juri Linkov
2021-03-15 17:25 ` Juri Linkov
2021-03-17 17:46 ` Juri Linkov
2021-03-17 22:31 ` Ergus
2021-03-18 9:20 ` Juri Linkov
2021-03-19 0:28 ` Gabriel
2021-03-22 11:07 ` Zhiwei Chen
2021-03-22 18:47 ` Juri Linkov
2021-03-23 12:17 ` Zhiwei Chen
2021-03-23 18:30 ` Repeat lambda (was: Some minor suggestions to Tab Bar) Juri Linkov
2021-03-26 6:00 ` Zhiwei Chen
2021-03-29 19:28 ` Juri Linkov [this message]
2021-04-05 21:03 ` Repeat lambda Juri Linkov
2021-04-11 23:40 ` Ergus
2021-04-12 2:25 ` Zhiwei Chen
2021-04-12 16:32 ` Juri Linkov
2021-04-13 19:35 ` Juri Linkov
2021-04-13 23:45 ` T.V Raman
2021-04-14 17:51 ` Juri Linkov
2021-04-14 5:37 ` Richard Stallman
2021-04-14 7:18 ` peat lambda Kévin Le Gouguec
2021-04-14 7:59 ` Repeat lambda Kévin Le Gouguec
2021-04-16 5:10 ` peat lambda Richard Stallman
2021-04-14 17:56 ` Repeat lambda Juri Linkov
2021-04-15 5:24 ` Richard Stallman
2021-04-05 21:19 ` Some minor suggestions to Tab Bar Juri Linkov
2021-04-06 3:16 ` Zhiwei Chen
2021-03-24 20:19 ` Juri Linkov
2021-03-25 0:47 ` Gabriel
2021-03-25 9:31 ` Juri Linkov
2021-03-26 5:52 ` Gabriel
2021-03-29 19:20 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtul7tcs.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=chenzhiwei03@kuaishou.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).