From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Tue, 06 Apr 2021 21:53:31 +0300 Organization: LINKOV.NET Message-ID: <87mtubz4ls.fsf@mail.linkov.net> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <878s5wmsjp.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32605"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Ergus , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 06 21:23:47 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTrIg-0008OU-PG for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 21:23:46 +0200 Original-Received: from localhost ([::1]:40058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTrIf-0000xm-Im for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 15:23:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTrHg-0008Ep-9U for emacs-devel@gnu.org; Tue, 06 Apr 2021 15:22:44 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:46607) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTrHc-0004Ew-0B for emacs-devel@gnu.org; Tue, 06 Apr 2021 15:22:43 -0400 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 6BBB7100003; Tue, 6 Apr 2021 19:22:36 +0000 (UTC) In-Reply-To: (Gregory Heytings's message of "Tue, 06 Apr 2021 00:44:19 +0000") Received-SPF: pass client-ip=217.70.178.231; envelope-from=juri@linkov.net; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267487 Archived-At: > Sorry, there was a typo in the previous patch, I attach a corrected one. Thanks, please see the comments below: > +(put 'beginning-of-buffer 'isearch-match-scroll t) > +(put 'end-of-buffer 'isearch-match-scroll t) > +(put 'scroll-up-command 'isearch-match-scroll t) > +(put 'scroll-down-command 'isearch-match-scroll t) > + > +(put 'beginning-of-buffer 'isearch-match-scroll-command 'isearch-beginning-of-buffer) > +(put 'end-of-buffer 'isearch-match-scroll-command 'isearch-end-of-buffer) > +(put 'scroll-up-command 'isearch-match-scroll-command 'isearch-scroll-up) > +(put 'scroll-down-command 'isearch-match-scroll-command 'isearch-scroll-down) Why such unnecessary duplication? When 'beginning-of-buffer' has the property 'isearch-match-scroll-command' this means it has a non-nil value. There is no need to duplicate this fact with isearch-match-scroll=t. > + :type '(choice (const :tag "Off" nil) > + (const tag "On" t)) === :tag