From: Michael Albinus <michael.albinus@gmx.de>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-devel@gnu.org
Subject: Re: master 5183123: Add Tramp recompilation
Date: Fri, 23 Apr 2021 19:58:52 +0200 [thread overview]
Message-ID: <87mttonaqr.fsf@gmx.de> (raw)
In-Reply-To: <878s59m0lq.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 23 Apr 2021 17:23:13 +0100")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
Hi Basil,
> It looks like package--user-installed-p isn't currently designed to be
> used in this way:
>
> 0. emacs -Q
> 1. (progn
> (require 'package)
> (require 'tramp)
> (setq read-extended-command-predicate
> #'command-completion-default-include-p)
> (read-extended-command))
> 2. C-j C-i
>
> Debugger entered--Lisp error: (wrong-type-argument package-desc nil)
> signal(wrong-type-argument (package-desc nil))
> package--user-installed-p(tramp)
> tramp-recompile-elpa-command-completion-p(tramp-recompile-elpa
> #<buffer *scratch*>)
> command-completion-default-include-p(tramp-recompile-elpa
> #<buffer *scratch*>)
>
> Should package--user-installed-p simply guard against a nil package
> descriptor?
That would be fine. But since Tramp must be backward compatible, I have
added a check in tramp-recompile-elpa-command-completion-p.
> Thanks,
Best regards, Michael.
prev parent reply other threads:[~2021-04-23 17:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210419095256.30298.23862@vcs0.savannah.gnu.org>
[not found] ` <20210419095259.0651220FD4@vcs0.savannah.gnu.org>
2021-04-23 16:23 ` master 5183123: Add Tramp recompilation Basil L. Contovounesios
2021-04-23 17:00 ` Stefan Monnier
2021-04-23 18:02 ` Michael Albinus
2021-04-23 20:02 ` Stefan Monnier
2021-04-23 20:17 ` Michael Albinus
2021-04-23 20:47 ` Stefan Monnier
2021-04-25 13:08 ` Michael Albinus
2021-04-23 17:58 ` Michael Albinus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mttonaqr.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).