From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Mon, 03 May 2021 11:16:42 +0200 Message-ID: <87mttcch39.fsf@gnus.org> References: <87a6pcqy7s.fsf@red-bean.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12208"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Emacs Development To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 03 11:22:39 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldUml-000321-BM for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 11:22:39 +0200 Original-Received: from localhost ([::1]:35554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldUmk-0007Ck-Dq for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 05:22:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldUhA-0008OD-KK for emacs-devel@gnu.org; Mon, 03 May 2021 05:16:53 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:57572) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldUh6-00072B-Lt for emacs-devel@gnu.org; Mon, 03 May 2021 05:16:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eMBLciF9XHFF99X55uwN6DrzGn9XTSEGNXf924GJUQI=; b=OJ7cagqsaGI74YCIWUG8JS/ZNn dE0XGZDAnlj8ZF+eTcLSpz0D1uMlivptv9L4KRlySZo8+zqxgc6QpbbLz1Dk5p1V2sBWhQ9o8laBX vo+hnYp9UdKMM/sRTBuQzoy+AI03MgrT30bD940yXhqC3ldhHu+/cTnojVlPcwi1sSF0=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldUh0-00032N-O2; Mon, 03 May 2021 11:16:45 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEX18e6IenU7KCq6 qqP////NhAZvAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UFAwgtITJYGwYAAAF1SURBVDjLnZRrloMg DIVD2YAJGzCwgdDsf29zA45infnT9Gg1H3kSJPpCWOoiysyiAwy91op3KLkQveoJtIm6O2V3I6oL 4KoFYOjTAgaDCfQOT3egbPjbwtPiSmrTZuMpfQDVsXbKLXj7A6jRG87JUcfdAu87kXWfIh+AjvQW C1wnuLmq/wFcrfOGarxH/DVGo7Q9LUquuyWT9wN43ayb9Bp1NFkAGpJ2YXkAaVT22kbheoENd9eC taOfi4UBNI+tD/a60rWuljmAyplViXidkmEi5tasLXFKvoUuVr0WgHGiXeoeJbZ0AI8oeEIG6rFv 7zmi1V7TokSmcraEIyR6mC2y6PyxH5hbnW2W+jlwI7nN+QEEHSyWDXs1gYxTAAs0tzg0uU+gA7Sw Mh+L0wUQOqatxWSdoHicgHASwxa36YpxKHCSMn4oPl8xmOdcTgNbY/ipyTdQfkEocdbyAU5PA4T4 BDeDKWkNbvRrmQ+LNz/lm0/PD+2LX9+nW6Z9AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA1LTAz VDA4OjQ1OjMzKzAwOjAwv2JNrwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNS0wM1QwODo0NToz MyswMDowMM4/9RMAAAAASUVORK5CYII= X-Now-Playing: The Style Council's _The Complete Adventures (1)_: "A Gospel" In-Reply-To: <87a6pcqy7s.fsf@red-bean.com> (Karl Fogel's message of "Sun, 02 May 2021 22:43:03 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268803 Archived-At: Karl Fogel writes: > I wanted to run this by folks here to get opinions/review before > committing. It stems from a suggestion by Oliver Taylor in a thread > on the Emacs Humanites mailing list (the thread is linked to from the > commit message). [...] > (bookmark-menu-confirm-deletion): New defcustom. In general, I think it's better to offer undo instead of prompting. That's not always possible, but I think in the bookmark case, that shouldn't be too difficult -- just register an undo action that inserts the items that were removed, I think? But if we want to do the prompt, just a tiny comment: > +(defcustom bookmark-menu-confirm-deletion t > + "Non-nil means prompt for confirmation when executing the deletion > +of bookmarks marked for deletion in a bookmark menu buffer. Nil > +means don't prompt for confirmation." > + :type 'boolean) :version should be added, and the first line should be a complete sentence. (And "nil" shouldn't be capitalised, even if it starts the sentence.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no