From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Tue, 25 May 2021 19:53:00 +0300 Organization: LINKOV.NET Message-ID: <87mtsibwjz.fsf@mail.linkov.net> References: <87zgwlb4xc.fsf@gmail.com> <87eedxrqz4.fsf@mail.linkov.net> <87r1hviwrw.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25069"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Daniel Mendler , monnier@iro.umontreal.ca, emacs-devel@gnu.org To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 25 19:35:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llaxM-0006Mw-Fb for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 19:35:04 +0200 Original-Received: from localhost ([::1]:57168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llaxL-0006en-EM for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 13:35:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llaU0-0004Bt-4K for emacs-devel@gnu.org; Tue, 25 May 2021 13:04:44 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39127) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llaTt-0002k2-VA for emacs-devel@gnu.org; Tue, 25 May 2021 13:04:42 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 7E662FF802; Tue, 25 May 2021 17:04:30 +0000 (UTC) In-Reply-To: <87r1hviwrw.fsf@gmail.com> (=?iso-8859-1?Q?=22Jo=E3o_T=E1vora?= =?iso-8859-1?Q?=22's?= message of "Mon, 24 May 2021 23:37:07 +0100") Received-SPF: pass client-ip=217.70.183.199; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269870 Archived-At: > I've seen this in read-extended-command--affixation.el indeed. I don't > understand: > > - the need for this window switch, but I might be missing something; > - if the need is to process in the same buffer, why one switches > windows; It can switch buffers instead of selecting windows. > - why it can't and shouldn't be done in the funcall locus by the frontend > (in this case minibuffer-completion-help) Because this requirement is specific only to read-extended-command--affixation, other uses might require other buffers to be current, so this doesn't remove the argument for having the affixation-function. > But if they exercise this freedom fully they're going to break the > layout of the frontend, like icomplete.el, which potentially does layout > calculations. Probably company.el or any other frontend is the same. > So not so much holding hands, more like saving feet from being shot :-). For many years we allowed the users to shoot themselves in the foot, and yet nobody did it :-) With the existing function 'display-sort-function' you can easily add new elements to the list of completions or remove the existing candidates. And that is not a problem in practice.