From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: scratch/ns/refactor 06d9e72 5/6: Move NS port toolbar handling to the window Date: Thu, 24 Jun 2021 16:59:48 +0200 Message-ID: <87mtrfqpej.fsf@gmail.com> References: <20210620155625.12886.44156@vcs0.savannah.gnu.org> <20210620155629.258B620B76@vcs0.savannah.gnu.org> <87h7hosqob.fsf@gmail.com> <874kdosk69.fsf@gmail.com> <87zgvfqs8f.fsf@gmail.com> <87r1grqrgi.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29252"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 24 17:01:14 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwQqw-0007Ty-MF for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Jun 2021 17:01:14 +0200 Original-Received: from localhost ([::1]:44116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwQqv-000806-KF for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Jun 2021 11:01:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwQpe-0006tV-97 for emacs-devel@gnu.org; Thu, 24 Jun 2021 10:59:54 -0400 Original-Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:35431) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lwQpc-0001J1-Gv for emacs-devel@gnu.org; Thu, 24 Jun 2021 10:59:54 -0400 Original-Received: by mail-wr1-x42e.google.com with SMTP id m18so7023474wrv.2 for ; Thu, 24 Jun 2021 07:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=WTOK9Vtt3KGcoJoKBhxz4B1cPMHfM+IiBLcZyd1Y5ks=; b=TsDRw0U4dCZN+9FieX90j+vx+BoyU8akL6otDDg7z0DA4fZOZUUGx/F7nDswuOGJWb 5uFOHDgpLs7CA51w4rwL4+NowTtuHUIfEPciMwhlWB90+GhQ999ML03/y/eGswcd4Imm eQ0e1KRDOdH2G9K1W5iDJgzr780OJ1m8cZOXyj/MtgPL/EyjXOAzKcultB2328fgadPB uwWPnK53cbB16OfVDh1NlD+TLC/RpvM1l+ICO+1//zAP5VXfWiiUH4LDbccEDlxM3tUB 18PU4hj9CzcgGgq5XJ0CwVuALm6opeW7iCT3BjFfggLhH+5j4qgwy9Qgtsn1Qk19Ku7Y vzcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=WTOK9Vtt3KGcoJoKBhxz4B1cPMHfM+IiBLcZyd1Y5ks=; b=uHt440diI3rR99Fo8KKRIF4+3w08/3KZeceVS2rbseNK3nCeTHWP7a3f2c9Pqt2ntr y+H29fh85AZHk8fyjd9roXtvLVfNtFsMaN/UBQ7dAGQ3fsnVP+osil6+MNXdZ7U04sTZ 9v8MJnY0o+BwKYlOT27GEmGS8R/caD6lnrsNGGF1hhOJnwLnP4uG895JaG4cBUmwi89J vvitcUO91Y2MVapI7ppyX1LdNIN5os8GWPtAbGPBncvDsTICm65r4hYq/BRBcKvHHb+F BjLLN7ZRc7H5RnVTH5tS2kP4vjQmRHtTcXnuKCFLivEL5j34pbwyzd0yMO1TgpuU+B3w p43A== X-Gm-Message-State: AOAM532U2JX4+dcCvbAThKweyvSDTYH2DGT9wraLIXHfzc47KSO9nCLN EwyZio6P3Dg0p75zgVb2CWf121PfNVs= X-Google-Smtp-Source: ABdhPJxSqCND+Tl9q5Jvtpi787zvTfHNlabCE5OCMO32nUfCcUaYseUgTwjco7AdQgY4f6hYwQelBQ== X-Received: by 2002:a5d:4983:: with SMTP id r3mr4967488wrq.184.1624546790710; Thu, 24 Jun 2021 07:59:50 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id r12sm3729791wrn.2.2021.06.24.07.59.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 07:59:49 -0700 (PDT) In-Reply-To: (Alan Third's message of "Thu, 24 Jun 2021 15:32:37 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=rpluim@gmail.com; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271005 Archived-At: >>>>> On Thu, 24 Jun 2021 15:32:37 +0100, Alan Third said: Alan> On Thu, Jun 24, 2021 at 04:15:25PM +0200, Robert Pluim wrote: >> >>>>> On Thu, 24 Jun 2021 15:07:33 +0100, Alan Third said: >> Alan> On Thu, Jun 24, 2021 at 03:05:43PM +0100, Alan Third wrote: >> >> If you revert 99adf4b2af is the menu behaviour better, worse or the >> >> same? >> Alan> Oops, sorry, 982ecc5aa9. I rebased my local copy onto master, so it Alan> doesn't match what you'll be using just now. >> >> Yes. Better with that reverted. Alan> Actually, if it's not too much hassle could you check whether just Alan> commenting out the lines: Alan> [outerpool release]; Alan> outerpool = [[NSAutoreleasePool alloc] init]; Alan> in ns_select fixes the problem, or does the whole commit need Alan> reverted? Commenting out just those lines is not enough. Alan> The real solution to this problem is, I think, the old threadify all Alan> the things, which is what some of the refactoring in this branch is Alan> intended to make easier. The two great problems in computer science are naming, scope creep, and off-by-one errors Robert --