unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: amk@amk.ie
Cc: emacs-devel@gnu.org, Tassilo Horn <tsdh@gnu.org>
Subject: Re: About SASL authentication in rcirc
Date: Tue, 29 Jun 2021 08:04:47 +0000	[thread overview]
Message-ID: <87mtr9m6zk.fsf@posteo.net> (raw)
In-Reply-To: <d1b306561fcd5cc9a6a4b09c23c3f971@amk.ie> (amk@amk.ie's message of "Mon, 28 Jun 2021 12:46:01 +0000")


Sorry for my late response,

amk@amk.ie writes:

> June 28, 2021 11:36 AM, "Tassilo Horn" <tsdh@gnu.org> wrote:
>
>> Hi Alex,
>> 
>> thanks for bringing SASL authentication to rcirc. I'm using the
>> rcirc-update branch of Philip for my IRC needs where Philip has
>> cherry-picked your commit implementing SASL authentication for rcirc.
>> So obviously I wanted to try that out and changed my
>> 
>> --8<---------------cut here---------------start------------->8---
>> (setq rcirc-authinfo
>> `(("libera" nickserv "tsdh" ,th/nickserv-password-liberachat)))
>> --8<---------------cut here---------------end--------------->8---
>> 
>> to
>> 
>> --8<---------------cut here---------------start------------->8---
>> (setq rcirc-authinfo
>> `(("libera" sasl "tsdh" ,th/nickserv-password-liberachat)))
>> --8<---------------cut here---------------end--------------->8---
>> 
>> and restarted my rcirc session after rebuilding emacs.
>> 
>> After that, the *irc.libera.chat* buffer contained a message that tsdh
>> is a registered nick but not the message afterwards that I'm
>> successfully registered now (as it is the case with nickserv
>> authentication). And when querying NickServ, it told me that I'm not
>> logged it.
>> 
>> If I understand SASL/IRC correctly, it should have logged in immediately
>> on connecting, right?
>> 
>> So apparently, it seems that it didn't work when I've tried. I'd be
>> happy to debug where it fails if you give me some pointers what to look
>> for.
>> 
>> Bye,
>> Tassilo
>
> Hey, 
>
> Correct, It should authenticate automatically
>
> I think the issue is that some of the original sasl commit got lost in
> cherry picking. I've attached a patch that fixes it, I'm not sure if
> there is a better place to send a patch to a branch.

That was probably the issue, I didn't get around to properly test it
yet. Sorry about that.

> Thanks,
> Alex
>
>

-- 
	Philip K. 



      parent reply	other threads:[~2021-06-29  8:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 10:36 About SASL authentication in rcirc Tassilo Horn
2021-06-28 12:46 ` amk
2021-06-28 19:35   ` Tassilo Horn
2021-06-28 19:58     ` Tassilo Horn
2021-06-28 20:12     ` Alex McGrath
2021-06-29  4:58       ` Tassilo Horn
2021-06-29  8:04   ` Philip Kaludercic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtr9m6zk.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=amk@amk.ie \
    --cc=emacs-devel@gnu.org \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).