From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 396355f: Re-fix charset issues when yanking non-plain-text elements Date: Thu, 11 Nov 2021 12:54:17 +0100 Message-ID: <87mtma7vrq.fsf@gnus.org> References: <83mtmb0wiv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16966"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 11 12:55:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml8fc-0004C2-Gv for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Nov 2021 12:55:08 +0100 Original-Received: from localhost ([::1]:35140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ml8fb-0001yh-FN for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Nov 2021 06:55:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml8ew-0000mN-I5 for emacs-devel@gnu.org; Thu, 11 Nov 2021 06:54:26 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=43006 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml8ev-0000f8-0M; Thu, 11 Nov 2021 06:54:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iqhhMZkWwEaAeN7hrqVseLKZPKVPl+7TNNZg8/3DTec=; b=fRdLS54yNjH0jfHfnqDHG01DUZ xKDm3h9cEr94cTpoSDnahHzQo3Gsh5OcWQrxK2kRXZH7f7G5nuGRBvz+FSogT7UjUkVlXPRBeofLm UHWBP3jNbBmzDpCoRZh9WphpLLaNcUn37pKYqBn8REU7svvAWMSenFamuNFysHvmss1U=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml8eo-0005NN-Ab; Thu, 11 Nov 2021 12:54:21 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEXO1dWNcDX////Y 16zIAAAAAWJLR0QCZgt8ZAAAAAlwSFlzAAALEgAACxIB0t1+/AAAAAd0SU1FB+ULCwo0LK7pjEMA AACNSURBVCjP3Y9BDgMhCEUxkb1N5D6Q1L0mcP+rDKOOdNFtNzUx4Ql8/wf4x4PWT01mesB+Cven 6RPgK/AsdMF6zUngiBFlYCh7vhPHsrYIqZYDWi0xpn0QPjBEYg5JFUPAtD7ORndy81MFxYxkC9YJ 3rhlJCWzxiunC6PZNvp2AyuOd/nlmUqZK8Did09dr8clJGwSuaAAAABaZVhJZk1NACoAAAAIAAUB EgADAAAAAQABAAABGgAFAAAAAQAAAEoBGwAFAAAAAQAAAFIBKAADAAAAAQACAAACEwADAAAAAQAB AAAAAAAAAAAASAAAAAEAAABIAAAAAR9S9zQAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMTEtMTFU MTA6NTI6NDQrMDA6MDAYV1QeAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTExLTExVDEwOjUyOjQ0 KzAwOjAwaQrsogAAABd0RVh0ZXhpZjpZQ2JDclBvc2l0aW9uaW5nADGsD4BjAAAAMHRFWHRpY2M6 Y29weXJpZ2h0AENvcHlyaWdodCAyMDAwIEFkb2JlIFN5c3RlbXMsIEluYy6pb7Z0AAAAKXRFWHRp Y2M6ZGVzY3JpcHRpb24AVS5TLiBXZWIgQ29hdGVkIChTV09QKSB2MqZOuwAAAAAASUVORK5CYII= X-Now-Playing: Herbert's _Musca_: "Tell Me A Secret feat. =?utf-8?Q?Si?= =?utf-8?Q?=C3=A2n?= Roseanna" In-Reply-To: <83mtmb0wiv.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 11 Nov 2021 13:19:52 +0200") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279247 Archived-At: Eli Zaretskii writes: > The old code took the data-type from the value of the > foreign-selection property, but now we disregard that. Is that on > purpose? Yes. That made even binary data (like images) be mis-decoded. Perhaps the logic here should be changed altogether -- and make all the backend selection functions do the decoding themselves (since the Windows one does it). >> + ;; Guess at the charset for types like text/html >> + ;; -- it can be anything, and different >> + ;; applications use different encodings. >> + ((string-match-p "\\`text/" (symbol-name data-type)) >> + (decode-coding-string >> + data (car (detect-coding-string data)))) > > Did you really need the explicit call to detect-coding-string? AFAIR, > decode-coding-string does that automatically if needed. Did that fail > in some case? Can you give a nil to decode-coding-string as the coding system? It's not documented. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no