From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: master c6dd8dd: * lisp/emacs-lisp/macroexp.el: Improve last change
Date: Thu, 02 Dec 2021 16:49:12 +0100 [thread overview]
Message-ID: <87mtlj0zyf.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkmk5Bjt+=_p=Jd1j74weOknBUnqaeRN8CTQ_A3hN2GCYww@mail.gmail.com> (Stefan Kangas's message of "Thu, 2 Dec 2021 04:48:55 -0800")
Stefan Kangas <stefankangas@gmail.com> writes:
>>> Don't burp when `byte-compile-warning-enabled-p` is not yet defined.
>>> And use the call that we had already instead of adding a new one.
>>
>> This (or something else recently) seems to lead to a failure in
>
> I've just finished bisecting these recently introduced errors and this
> commit is indeed the culprit.
I've now changed it to not bug out, but I haven't looked closely at the
logic -- why is the `warning' a nil there anyway?
> I'm seeing this as well:
>
> 4 files did not contain any tests:
> lisp/net/ntlm-tests.log
> lisp/emacs-lisp/eieio-tests/eieio-tests.log
> lisp/emacs-lisp/eieio-tests/eieio-test-persist.log
> lisp/cedet/srecode/fields-tests.log
>
> With errors like:
>
> In toplevel form:
> lisp/emacs-lisp/eieio-tests/eieio-tests.el:36:1: Error: Wrong number
> of arguments: #<subr byte-compile-warning-enabled-p>, 0
> make[3]: *** [Makefile:165: lisp/emacs-lisp/eieio-tests/eieio-tests.elc] Error 1
These also seem to work now...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-12-02 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211202035200.9877.9609@vcs0.savannah.gnu.org>
[not found] ` <20211202035202.04FD820ABB@vcs0.savannah.gnu.org>
2021-12-02 12:31 ` master c6dd8dd: * lisp/emacs-lisp/macroexp.el: Improve last change Lars Ingebrigtsen
2021-12-02 12:48 ` Stefan Kangas
2021-12-02 15:49 ` Lars Ingebrigtsen [this message]
2021-12-02 19:58 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtlj0zyf.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).