From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 15ac51e0fd: Merge branch 'feature/completions-customs' Date: Tue, 22 Mar 2022 17:28:59 +0800 Message-ID: <87mthijpyc.fsf@yahoo.com> References: <164793742180.2038.4306130819331318764@vcs2.savannah.gnu.org> <20220322082342.60DC3C051F4@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20265"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Juri Linkov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 22 10:31:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWarG-00052t-5m for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Mar 2022 10:31:18 +0100 Original-Received: from localhost ([::1]:59424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWarE-0000lB-Qv for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Mar 2022 05:31:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWapO-0007L5-6O for emacs-devel@gnu.org; Tue, 22 Mar 2022 05:29:22 -0400 Original-Received: from sonic305-20.consmr.mail.ne1.yahoo.com ([66.163.185.146]:45711) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nWapM-0001W5-6u for emacs-devel@gnu.org; Tue, 22 Mar 2022 05:29:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647941356; bh=7QWBj+KPaQDij18HKSGgPs/36GL8iCHoHaicKCChh20=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=pydP6tQ+MaLC+O7NRLMgyZ1iL4lG77JIhLH/2fzedvY+OcarvUAo6AnJmeDAQIVaQV2KaEP1Nan10FsxYQ+KFtnN66AAY80Oy3NQJerMEItOpmnLxc7et1Qz4EQ3/dUEAn47SAIPxHmGfJuI0l7TDFElE0E/7t9ds7KNtSY7RwCoEYy1BU0mjkxfZOwOpV9V4UZZcW2Q+qVNeZ4xUVVrKN8TJN5B/lNDOL0tq1wUy/DrdAMyfWBd2OuBsbfbfsPJQcypnjdEm1jxY/BDk//0VDj5kc51JHChgkpYxKprWtBbuViDTthaKKKa34br2LudT67zpl+qwiNrSHT5AjURfQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647941356; bh=e2xlI/MoBdS9bv6hkzGMl6e+wR1gQXSWqLVbeicroda=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=taeWdij+AseW4VPu6TWex/xWhrsV98JxW1Rkpd5ZcLwTErhrWaTsYE0r+5fk5d5LeqRPNt02VmSxsMJhgR76M5dy4qxC/Wrw+Mrkyi91D/E8IMcGJJ5gaEq/JI8PxPJ9wERiXccOlSz8x2QdZjwQKHcHSUBikstgofdWF/b0YMdmX6xXxIdAyE5ZjGwXDuOGLD78ONMGll9Uie5IxJn3bnIFXi+av9ZQawbwAtDCcoK6/AqvyXRwVNYiSZ/3UWRNEgADqAv8621Hk+S/TJWZmiAII3YWSpYRsLh9mmQQOAu3322WoepFZ1ADhnTfyCnAYmd2pG8UHy1zXN1qFe9vfQ== X-YMail-OSG: NKWhECEVM1n8NUEO6ZQP.EbOiZPT8ZEbkpwXX9KvacuvXiJFMqoMawV2ApKPL5M quaugAHw8Up2DJo94T8Hm6GPzziu4k0HW7eF6M3beXmOp6iTFu3lujV3UisR8K4v_huJ3ghf4liN ctYP9ezbKlMu_U8YNy0VGC5Zpvc0PX1K3tyGT5I5IXnZCxoUo5Ts_LoHYRehEff4bgyqLM4oYkhj xNnVHHDmXXo4nYdUSjai.nGg8qhWndd.CLM2_oDw5NoHEe4UvxVRGl9pGPAgdpw3KRxHqCKDlXGV cBQEbjp.hpmPZEsa2d6UuEjdhrgDLU5URGpbQj5vmXGHh1m3uQS96__bE8YvQXv4hD2sdqIc6pMp zJSnV49VaB6zn7O1X.Wx_GpAOKbHjzxKFO4_YyhDxbm8..7F6NKRPURLgFyxHxP_EbBrKYe0xOCy Q4yvnV87E3Av1SzaABHKemSKj0htMiSYqkOfTUpqTU4ASUSXRbp6izKG_O2.GZ_IA14wcBl5Ql1G FFJwf_xVZrSBXv7DJmk0oNYMgrt4BBaj_b2dx5.QaoyQlA964FB3Xtg3_P2Cub5vkoqMW6G.tkI9 RcKtbdo8.2226eYK35OVLxLIF1.w.v82wF_eBxVTNxz5XzQFF_jnFJfNhcpJq1BQyCEfDSboADef 6uHZ1BJmWzsBd9WG3p1YtXPEQIpULhT7BzDwW18De5peYRZ.A0Tu13qJXuOKG7qvEA7q6plPMJsY PxArcQnnHHauZdv1.j3RtBrQZ4CiCDMigAETezrVejSVNAuGpuHukmE16UBfbNMlMqE0_7YOuBQi OBdqxqBNDNzqDBoNplI3BVJPGSky4A8sJTUkq7QQu7 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Tue, 22 Mar 2022 09:29:16 +0000 Original-Received: by kubenode502.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 5d18802d4f04abfc63af214719416ce1; Tue, 22 Mar 2022 09:29:07 +0000 (UTC) In-Reply-To: <20220322082342.60DC3C051F4@vcs2.savannah.gnu.org> (Juri Linkov's message of "Tue, 22 Mar 2022 04:23:42 -0400 (EDT)") X-Mailer: WebService/1.1.19894 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.185.146; envelope-from=luangruo@yahoo.com; helo=sonic305-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287349 Archived-At: Juri Linkov writes: > +(defcustom completions-header-format > + (propertize "%s possible completions:\n" > + 'face 'shadow > + :help "Please select a completion") > + "Format of completions header. > +It may contain one %s to show the total count of completions. > +When nil, no header is shown." > + :type '(choice (const :tag "No header" nil) > + (string :tag "Header format string")) > + :version "29.1") IHMO this should be off by default. It wastes a line of space in the completions buffer for no real gain, and it's distracting. Also, I don't know which part of this change causes the following behavior, but if I say M-x and then press TAB twice, the item at the start of the window displaying the completions buffer becomes highlighted, even though it isn't selected. That should also be off by default, since it's an unnecessary visual distraction. Thanks.