From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aleksandr Vityazev Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: srht Date: Thu, 19 May 2022 19:10:49 +0000 Message-ID: <87mtfdtk1y.fsf@posteo.org> References: <87tu9mu40v.fsf@posteo.org> <87leuyun2m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8311"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 19 21:27:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrlnz-0001yl-S4 for ged-emacs-devel@m.gmane-mx.org; Thu, 19 May 2022 21:27:28 +0200 Original-Received: from localhost ([::1]:48988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrlny-0001HM-D4 for ged-emacs-devel@m.gmane-mx.org; Thu, 19 May 2022 15:27:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrlY6-00043I-RC for emacs-devel@gnu.org; Thu, 19 May 2022 15:11:02 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:33443) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrlY1-000616-NQ for emacs-devel@gnu.org; Thu, 19 May 2022 15:11:00 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 6BF82240029 for ; Thu, 19 May 2022 21:10:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.org; s=2017; t=1652987453; bh=KYVS6wTPyum/3zKJ2z5UHfXmgHpXUzta89lyc5IldXQ=; h=From:To:Cc:Subject:Date:From; b=fmRuiLl9vqudorigyA8go+gcCb8RRcxjkgUf6gsOAmSJWtyTkg0D86ahIcd4ZQYBi VeKnRsw02U/HaUN4ya8mXTkZaJtaRuIXRzdMmQszMzQLTmxVa5NfQukYMNunRl35n8 MlyBzRYty6X8LWpXJYHNS+v/hd09wHiOEyOxbm6pyQyfET8bGI+4mzujCy3HfsEZNN OnNi8lhkgo3x1vF3Omb2ivVYVoLAmHAFW564QNeYvn8vvodnPnSV7pITlHcc/6tsjx i88HqctewLGCGN5cbCEA7WOGH/D5fXqQE+ggOFq+RCdbIfT4wEOA1l1bv7wOiIygT0 V7JMfd2QIOPEg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4L3zwC6F5dz6tmj; Thu, 19 May 2022 21:10:50 +0200 (CEST) In-Reply-To: <87leuyun2m.fsf@gnu.org> (Tassilo Horn's message of "Thu, 19 May 2022 06:56:12 +0200") Received-SPF: pass client-ip=185.67.36.65; envelope-from=avityazev@posteo.org; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 19 May 2022 15:20:40 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289988 Archived-At: On 2022-05-19, 06:56 +0200, Tassilo Horn wrote: > Aleksandr Vityazev writes: > >>>> No, in version 0.1 it is already possible to interact with any >>>> Sourcehut instance. Can be specified via the srht-domain variable. >>> >>> That's one variable, hence only one instance. >> >> Good point, now I understand, will be included in version 0.2. > > Out of curiosity, what are you planning to do? > > I didn't quite get Stefan's compaint to begin with. I would imagine one > sets srht-domain on a per-project basis, i.e., in a .dir-locals.el file. > Should the package cater for the possibility that a project's git is on > instance 1 but the tracker on instance 2? Or should there just be a way > to define all instances I want to interact with and then have an > convenient switch-command? Or should the instance be a mandatory > argument to all functions (which would also be ok if it's just a library > providing access to the srht API) and packages using srht should handle > the "which instance" aspect? Not to say that srht is a library that simply binds the Sourcehut REST API. There are also several commands to interact with. As a solution, I chose the latter by adding an extra mandatory argument for the functions. The available commands use srht-domains (list of instance domain names), where users can specify all the instances they want to interact with. When the command is invoked, it offers instance selection if srht-domains contains more than one. When used in conjunction with .dir-locals.el there is little change. -- Best regards, Aleksandr Vityazev