unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master af152ffab1: Don't freeze if the compositing manager crashes
Date: Sat, 30 Jul 2022 18:39:17 +0800	[thread overview]
Message-ID: <87mtcqlwa2.fsf@yahoo.com> (raw)
In-Reply-To: <83sfmj56m4.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Jul 2022 11:48:03 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Po Lu <luangruo@yahoo.com>
>> Cc: emacs-devel@gnu.org
>> Date: Sat, 30 Jul 2022 16:37:37 +0800
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> > Why not?
>> 
>> Because wait_reading_process_output will call read_socket_hook to read
>> events, and at that point it's too late to extract the event we want out
>> of the queue.
>
> Why too late?

Because read_socket_hook has already removed the event (which is
probably not the event we want) from the queue.

> Anyway, your change freezes Emacs for a whole second, which doesn't
> seem to be a good idea.

It only freezes in a rare situation, which is when the compositing
manager crashes after the user has explictly enabled frame
synchronization.



      reply	other threads:[~2022-07-30 10:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-30  6:03 master af152ffab1: Don't freeze if the compositing manager crashes Eli Zaretskii
2022-07-30  7:02 ` Po Lu
2022-07-30  8:06   ` Eli Zaretskii
2022-07-30  8:37     ` Po Lu
2022-07-30  8:48       ` Eli Zaretskii
2022-07-30 10:39         ` Po Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtcqlwa2.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).