From: Manuel Giraud <manuel@ledu-giraud.fr>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: How to walk a Lisp_String?
Date: Fri, 02 Sep 2022 13:40:53 +0200 [thread overview]
Message-ID: <87mtbi57i2.fsf@elite.giraud> (raw)
In-Reply-To: <83tu5qoxol.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Sep 2022 13:52:42 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Manuel Giraud <manuel@ledu-giraud.fr>
>> Cc: emacs-devel@gnu.org
>> Date: Fri, 02 Sep 2022 10:56:56 +0200
>>
>> > Why would you need to create a unibyte string? More importantly, why
>> > would you trust make_string to make the decision that is right for
>> > your purposes?
>>
>> Because it was written by Emacs' hackers… more seriously, for the
>> purpose of menu entries, I think that most strings will be unibyte ASCII
>> strings.
>
> ASCII strings can be unibyte or multibyte, Emacs does TRT with both.
> So you don't need to worry about that.
Duly noted.
>> But I thought I needed a Lisp_String in order to use some
>> other emacs interfaces.
>
> Depends on the interface.
For instance, face_at_string_position or fetch_string_char_advance 😉
[...]
> You probably modified display_menu_item, because I see no Lisp_String
> objects there no or Lisp_Object frame.
Yes obviously. Because I was trying to discuss the design (as you
suggested) but also, with informations from you, Po and Stefan, trying
to *do* something about it.
> So I still don't understand how you intend to put face information on
> your Lisp strings,
I'm still clueless about this. You said that I have to propertize them
so I think there is a C interface for this too.
> nor even how you produce those Lisp strings in a function that
> currently manipulates only C data types, without any Emacs-specific
> Lisp data types.
But I'm using Emacs-specific Lisp data types (and Emacs interfaces)! To
produce the Lisp strings from char *, I've used make_string.
[...]
> At least, yes. And then I'd expect the currently active
> (a.k.a. "selected") menu item to have a different face from the other
> items, so that the active menu item stands out on display and provides
> a visual feedback for the user moving the mouse to select menu items.
You're right. I guess that I'd have to introduce a menu-selected face.
But from where I am now, it will at a final stage.
--
Manuel Giraud
next prev parent reply other threads:[~2022-09-02 11:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 15:34 How to walk a Lisp_String? Manuel Giraud
2022-09-01 15:42 ` Stefan Monnier
2022-09-01 15:42 ` Eli Zaretskii
2022-09-01 15:49 ` Eli Zaretskii
2022-09-01 20:45 ` Manuel Giraud
2022-09-02 1:08 ` Po Lu
2022-09-02 6:32 ` Eli Zaretskii
2022-09-02 8:27 ` Po Lu
2022-09-02 10:36 ` Eli Zaretskii
2022-09-02 11:03 ` Po Lu
2022-09-02 11:15 ` Eli Zaretskii
2022-09-02 12:48 ` Po Lu
2022-09-02 13:17 ` Eli Zaretskii
2022-09-02 6:51 ` Manuel Giraud
2022-09-02 7:20 ` Eli Zaretskii
2022-09-02 8:31 ` Po Lu
2022-09-02 6:43 ` Eli Zaretskii
2022-09-02 7:18 ` Manuel Giraud
2022-09-02 7:30 ` Eli Zaretskii
2022-09-02 8:56 ` Manuel Giraud
2022-09-02 10:52 ` Eli Zaretskii
2022-09-02 11:40 ` Manuel Giraud [this message]
2022-09-02 12:51 ` Po Lu
2022-09-02 15:07 ` Manuel Giraud
2022-09-03 0:58 ` Po Lu
2022-09-03 5:46 ` Tomas Hlavaty
2022-09-03 6:19 ` Po Lu
2022-09-03 8:05 ` Tomas Hlavaty
2022-09-02 13:08 ` Eli Zaretskii
2022-09-02 14:58 ` Manuel Giraud
2022-09-02 15:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtbi57i2.fsf@elite.giraud \
--to=manuel@ledu-giraud.fr \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).