From: Philip Kaludercic <philipk@posteo.net>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/ef-themes 71fb847eca 2/2: Add FIXME about simplifying ef-themes-collection
Date: Sat, 17 Sep 2022 13:04:38 +0000 [thread overview]
Message-ID: <87mtaym9sp.fsf@posteo.net> (raw)
In-Reply-To: <87a66yw5d9.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Sat, 17 Sep 2022 15:30:10 +0300")
Protesilaos Stavrou <info@protesilaos.com> writes:
>> From: Philip Kaludercic <philipk@posteo.net>
>> Date: Sat, 17 Sep 2022 10:40:32 +0000
>
>> [... 21 lines elided]
>
>>> +;; FIXME 2022-09-16: Maybe the `ef-themes-collection' should just
>>> +;; combine the `ef-themes-light-themes' and `ef-themes-dark-themes'?
>>> +;; This duplication seems unnecessary.
>>> (defconst ef-themes-collection
>>> '(ef-autumn
>>> ef-dark
>>
>> Is there any reason you couldn't just replace the definition with
>>
>> (seq-union ef-themes-light-themes ef-themes-dark-themes)
>>
>> ?
>
> You mean to include that in the relevant functions and remove the
> 'ef-themes-collection' altogether?
I was thinking of replacing the
'(ef-autumn
ef-dark
with the `seq-union' call from above.
> I was thinking that having a
> standalone variable is easier for documentation purposes. Same for
> 'ef-themes-{dark,light}-themes'.
>
> Though yes, your code does what I want.
prev parent reply other threads:[~2022-09-17 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166335465493.17197.7832233071746944297@vcs2.savannah.gnu.org>
[not found] ` <20220916185735.5AAFBC00874@vcs2.savannah.gnu.org>
2022-09-17 10:40 ` [elpa] externals/ef-themes 71fb847eca 2/2: Add FIXME about simplifying ef-themes-collection Philip Kaludercic
2022-09-17 12:30 ` Protesilaos Stavrou
2022-09-17 13:04 ` Philip Kaludercic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtaym9sp.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=info@protesilaos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).