unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
	 emacs-devel <emacs-devel@gnu.org>, Alan Mackenzie <acm@muc.de>,
	 Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: master 60102016e4: Abolish max-specpdl-size (bug#57911)
Date: Tue, 20 Sep 2022 15:14:13 +0200	[thread overview]
Message-ID: <87mtaumbmi.fsf@gmx.de> (raw)
In-Reply-To: <9311F07F-9D1C-41F5-9D39-0B6233CA6A55@acm.org> ("Mattias Engdegård"'s message of "Tue, 20 Sep 2022 14:49:40 +0200")

Mattias Engdegård <mattiase@acm.org> writes:

Hi Mattias,

>> Tramp needs this for Emacs 26. I've wrapped it with `with-no-warnings'.
>
> Thank you, but maybe silencing all warnings in the affected code was a cudgel heavier than the situation called for?

Well, I wanted to use `with-suppressed-warnings', but this exists in
Emacs 27+ only.

> Perhaps something like this would do:
>
>> (defmacro tramp--with-max-specpdl-size (new-limit &rest body)
>>   (declare (indent 1))
>>   (if (< emacs-major-version 29)
>>       `(let ((max-specpdl-size ,new-limit)) . ,body)
>>     `(progn . ,body))))

It isn't Tramp code which changes frequently, so I guess we could keep
it as it is. And with Tramp 2.7 (Emacs 30), Emacs 26 won't be supported
any longer, and Tramp can get rid of it.

Let's work on a soonish Emacs 29 release ! :-)

Best regards, Michael.



  parent reply	other threads:[~2022-09-20 13:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166360889903.6127.6574959318930089210@vcs2.savannah.gnu.org>
     [not found] ` <20220919173459.EC224C00872@vcs2.savannah.gnu.org>
2022-09-19 18:50   ` master 60102016e4: Abolish max-specpdl-size (bug#57911) Lars Ingebrigtsen
2022-09-20 12:15     ` Michael Albinus
2022-09-20 12:18       ` Lars Ingebrigtsen
2022-09-20 12:49       ` Mattias Engdegård
2022-09-20 13:07         ` Lars Ingebrigtsen
2022-09-20 13:14         ` Michael Albinus [this message]
2022-09-20 14:56         ` Alan Mackenzie
2022-09-23  8:32           ` Mattias Engdegård
2022-09-27  8:47     ` Alan Mackenzie
2022-09-27  9:01       ` bug#57911: " Mattias Engdegård
2022-09-27 10:14         ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtaumbmi.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=mattiase@acm.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).