From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Wed, 19 Oct 2022 07:08:34 +0000 Message-ID: <87mt9s47f1.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <20220214140020.04438C00891@vcs2.savannah.gnu.org> <87bkqmqpvb.fsf@posteo.net> <871qris3xb.fsf@gnus.org> <877d1aqoc1.fsf@posteo.net> <87edvhqdrb.fsf@gnus.org> <871qrh2hh6.fsf@posteo.net> <87mta5oyec.fsf@gnus.org> <87sfjx10x1.fsf@posteo.net> <875ygsp0ng.fsf@gnus.org> <87h70c9bu4.fsf@posteo.net> <874jw73cjy.fsf@posteo.net> <87edv72z11.fsf@posteo.net> <87czaq1i3k.fsf@posteo.net> <87fsfkhnhm.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40368"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 19 09:16:24 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ol3JQ-000AMm-Tm for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Oct 2022 09:16:24 +0200 Original-Received: from localhost ([::1]:44438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ol3JP-00044y-Du for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Oct 2022 03:16:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ol3C6-0006Lb-5T for emacs-devel@gnu.org; Wed, 19 Oct 2022 03:08:50 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:33753) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ol3Bw-0006Ad-1i for emacs-devel@gnu.org; Wed, 19 Oct 2022 03:08:48 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D8F4F240104 for ; Wed, 19 Oct 2022 09:08:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1666163315; bh=hNMsO5kX+cqsIn9sOWeKy/QQMH5DmQPE/tnYqO7+Pz4=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=RcwCld5gR+WgcD7ji9HiSvanfzW4ZG0AdvSo3taL1EYsrVRiHj2urOjBNU6pL7um7 k7IPk1QjxAxJTbAHXRhwTEhy+xAIKfe0TMlfveqLcbyXIea8eNd9UaKoZTcyU0iaB4 0DHXpC7p/GiphWduf++/sZEEjhGXbQ41SUvEz5vk9eR/RmYlXTzfW7c9tpIK+K0iTQ yRv2jNyZeku8VI9dDq17s40OD1zxkRgCCSn5H4dvSwzh4t9ABDBIu3z0aWyQVSFdZP EezVy13w0FKC4bgLLLAHcP2DXQ1QfacEq+vKsvUot5xxpNo2fzmCWmtr2Kx+70OWx5 0gMEpmX01I7uw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MshfB60d8z9rxN; Wed, 19 Oct 2022 09:08:34 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Tue, 18 Oct 2022 17:40:18 -0400") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298105 Archived-At: Stefan Monnier writes: >> I have pushed a first draft and it appears to work. It doesn't yet >> handle all attribute (such as :doc), but that should be doable when I >> find the time. > > Side note: installing packages from Git (like what you're implementing > in the `package+vc` branch) is already one of the functionalities > supported by `elpa-admin.el` so it would be good to try and share/reuse > that code as much as possible. That is only possible insofar I don't have to rely on Git features, since package-vc intends to be VC-generic. > Actually part of `elpa-admin.el` might also be helpful for the > ELPA-bundling feature. > > So we should move more of `elpa-admin.el` into Emacs's own code. As part of `package-vc' or as a new module? >> I wanted to add support for elpa-admin.el, > > Not sure what you mean. > >> and it will boil down to >> something like this: >> >> (with-temp-buffer >> (let ((filename (expand-file-name "elpa-packages" dir)) >> (standard-output (current-buffer))) >> ;; Remove and compress the contents of the "elpa-pacakges" >> (prin1 (elpaa--get-specs)) >> (write-region nil nil filename))) >> >> but I am uncertain where to add it, so that it only runs when necessary. >> Do you have any ideas? > > Are you talking about the code which will run on `elpa.gnu.org` that is > supposed to push some kind of copy of `elpa-packages` to the web site so > clients can download it? Yes exactly. > We just need to export this as a function which we can then run from > a cron job (tho you could also just call it from > `elpaa-batch-make-all-packages`, so it's run as part of the main cron > job). But note that we can't just write out (elpaa--get-specs): we also > need to remove the `:core` packages and replace the nil `:url`s with > URLs pointing to `elpa.git` or `nongnu.git` (with corresponding `:branch`). I would prefer the latter and will try that out. > > Stefan