From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Sat, 29 Oct 2022 16:00:23 +0000 Message-ID: <87mt9epqlk.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <83tu455a5s.fsf@gnu.org> <87a65v2ytp.fsf@posteo.net> <834jw33rmx.fsf@gnu.org> <87pmer0xtz.fsf@posteo.net> <83wn8z2aze.fsf@gnu.org> <878rle1i0k.fsf@posteo.net> <87ilkelc10.fsf@posteo.net> <878rl6syg8.fsf@posteo.net> <87zgdjqcu0.fsf@posteo.net> <87zgdivc3f.fsf@posteo.net> <874jvqv2u3.fsf@posteo.net> <875yg6qtbl.fsf@posteo.net> <87ilk33lqk.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28243"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Richard Stallman , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 29 18:02:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oooHX-00077Q-Gx for ged-emacs-devel@m.gmane-mx.org; Sat, 29 Oct 2022 18:01:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oooGC-0002XM-Gm; Sat, 29 Oct 2022 12:00:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oooG5-0002V3-1t for emacs-devel@gnu.org; Sat, 29 Oct 2022 12:00:29 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oooG2-0005m1-Mq for emacs-devel@gnu.org; Sat, 29 Oct 2022 12:00:28 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9936F240108 for ; Sat, 29 Oct 2022 18:00:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667059224; bh=hbvKumvEGpcJZg5YKkkxG5XZa2XMyV8hrdyc8R5Ibv4=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=RARUQL9HMXXGimDZA3szrKlXWIHDQfHaBwDIesohNRK7sbbVjv7kCR6xG+Zwh8CM8 Q5iUo4NRqhysBMeL+HdL2nLmqHDrms9fHVUNDsYop7+GwZJvAykGyc2BqPv5kw/COB ee50I5T8+LF4+to9pESBotx5e8hFvYpeOpL1tqZeybuzEZ4ZdT5Uzmv+QLeTF5vI3W +kv4KgcADK5lASWmUUQ0i5rSKm7xl3YsGCuiV/H004JEy2aptZZyU1wqZGS4bGbLVw Sni9+9F9ozHwT9d92fxqqduCZXX5lQ3VPswS79dLov09hUtTty3B7QSaE/rPstOdOF vG56gi9oNDUgw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N03zC6f8Vz9rxH; Sat, 29 Oct 2022 18:00:23 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Sat, 29 Oct 2022 11:39:18 -0400") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298766 Archived-At: Stefan Monnier writes: >> + (list (mapcan >> + (lambda (spec) >> + (let ((rel (ignore-errors (elpaa--get-last-release spec)))) >> + (when rel >> + (nconc spec (list :release-rev (cdr rel))))) >> + (pcase spec >> + (`(,name :url nil . ,rest) >> + `((,name :url ,(concat "https://git.sv.gnu.org/git/" elpaa--gitrepo) >> + :branch ,(concat elpaa--branch-prefix (car spec)) >> + ,@rest))) >> + (`(,_ :core ,_ . ,_) nil) ;not supported >> + (_ (list spec)))) >> + specs) >> + :version 1 :default-vc 'Git) > > IMO we should strive to reduce a package's spec. Ideally they should > just be a URL. I agree. > We're not there yet, but the above adds info which we > can (and do in `elpa-admin.el`) extract from the VCS, so it's going > "backward". IOW, it's making things worse rather than better. You mean the addition of :release-rev, right? Yes, it could be extracted from the VCS, but finding a generic system is tricky as you have mentioned. How about a new VC method `last-change' that takes a region and returns the last revision that affected it. Any backend that supports `annotate' ought to be able to determine it, right?