* Re: master e494ca4f4d 6/7: Fix treesit_record_change in casify_region [not found] ` <20221122090711.6DCF5C0E4BB@vcs2.savannah.gnu.org> @ 2022-11-22 9:35 ` Po Lu 2022-11-22 19:16 ` Yuan Fu 0 siblings, 1 reply; 3+ messages in thread From: Po Lu @ 2022-11-22 9:35 UTC (permalink / raw) To: emacs-devel; +Cc: Yuan Fu Yuan Fu <casouri@gmail.com> writes: > #ifdef HAVE_TREE_SITTER > - treesit_record_change (start_byte, old_end_byte, CHAR_TO_BYTE (end)); > + treesit_record_change (start_byte, old_end_byte, CHAR_TO_BYTE (orig_end + added)); > #endif > - } > > return orig_end + added; > } This is 88 columns! Would you please fill it to 80? ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master e494ca4f4d 6/7: Fix treesit_record_change in casify_region 2022-11-22 9:35 ` master e494ca4f4d 6/7: Fix treesit_record_change in casify_region Po Lu @ 2022-11-22 19:16 ` Yuan Fu 2022-11-23 0:41 ` Po Lu 0 siblings, 1 reply; 3+ messages in thread From: Yuan Fu @ 2022-11-22 19:16 UTC (permalink / raw) To: Po Lu; +Cc: emacs-devel > On Nov 22, 2022, at 1:35 AM, Po Lu <luangruo@yahoo.com> wrote: > > Yuan Fu <casouri@gmail.com> writes: > >> #ifdef HAVE_TREE_SITTER >> - treesit_record_change (start_byte, old_end_byte, CHAR_TO_BYTE (end)); >> + treesit_record_change (start_byte, old_end_byte, CHAR_TO_BYTE (orig_end + added)); >> #endif >> - } >> >> return orig_end + added; >> } > > This is 88 columns! Would you please fill it to 80? Sure, but now I’m confused. IIRC some style changes made to treesit.c unwraps some lines into long lines, which is why I didn’t wrap this line. What exactly is our policy? Yuan ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master e494ca4f4d 6/7: Fix treesit_record_change in casify_region 2022-11-22 19:16 ` Yuan Fu @ 2022-11-23 0:41 ` Po Lu 0 siblings, 0 replies; 3+ messages in thread From: Po Lu @ 2022-11-23 0:41 UTC (permalink / raw) To: Yuan Fu; +Cc: emacs-devel Yuan Fu <casouri@gmail.com> writes: > Sure, but now I’m confused. IIRC some style changes made to treesit.c > unwraps some lines into long lines, which is why I didn’t wrap this > line. What exactly is our policy? If any lines were made longer than 80 columns, then it was a mistake. Our policy is to keep everything inside column 80. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-23 0:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <166910803045.16429.10643976346308966505@vcs2.savannah.gnu.org>
[not found] ` <20221122090711.6DCF5C0E4BB@vcs2.savannah.gnu.org>
2022-11-22 9:35 ` master e494ca4f4d 6/7: Fix treesit_record_change in casify_region Po Lu
2022-11-22 19:16 ` Yuan Fu
2022-11-23 0:41 ` Po Lu
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).