From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: "João Távora" <joaotavora@gmail.com>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot
Date: Thu, 15 Dec 2022 10:12:05 +0100 [thread overview]
Message-ID: <87mt7pav4q.fsf@gmx.de> (raw)
In-Reply-To: <CADwFkmk+XjOF+edYqy69orH+Swvrdd7MnBPzqbB=h1qY-Dg_QQ@mail.gmail.com> (Stefan Kangas's message of "Wed, 14 Dec 2022 13:42:31 -0800")
Stefan Kangas <stefankangas@gmail.com> writes:
Hi Stefan,
> More conventions are in use than that, and I couldn't confidently say
> which is the preferred one. Probably it's not that important, as long
> as every file consistently uses one or the other.
Yes.
> FWIW, I don't see any major benefit to having "-test" in the test name,
> as the fact that it's a test is immediately obvious in all contexts
> where you see them. So it mostly just makes the test names longer.
For me, who doesn't know the eglot codebase, it is helpful to see,
whether a Lisp object belongs to eglot or eglot-tests.
Prior my changes, there were even the defun `eglot-lsp-abiding-column'
and the ert-deftest `eglot-lsp-abiding-column'. Terrible!
Best regards, Michael.
next prev parent reply other threads:[~2022-12-15 9:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167080394233.4339.5863353994038854528@vcs2.savannah.gnu.org>
[not found] ` <20221212001223.E9A9DC004BE@vcs2.savannah.gnu.org>
2022-12-12 8:34 ` emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot Stefan Kangas
2022-12-12 9:52 ` João Távora
2022-12-12 11:26 ` Stefan Kangas
2022-12-12 11:56 ` João Távora
2022-12-12 21:52 ` Stefan Kangas
2022-12-13 8:49 ` Michael Albinus
2022-12-13 19:23 ` Stefan Kangas
2022-12-14 9:55 ` Michael Albinus
2022-12-12 10:32 ` Michael Albinus
2022-12-12 10:37 ` João Távora
2022-12-13 19:10 ` Michael Albinus
2022-12-13 20:18 ` João Távora
2022-12-14 9:57 ` Michael Albinus
2022-12-14 12:58 ` João Távora
2022-12-14 14:11 ` Michael Albinus
2022-12-14 15:46 ` João Távora
2022-12-14 17:41 ` Stefan Monnier
2022-12-14 21:42 ` Stefan Kangas
2022-12-15 9:12 ` Michael Albinus [this message]
2022-12-15 12:08 ` João Távora
2022-12-12 10:59 ` Michael Albinus
2022-12-12 11:03 ` João Távora
2022-12-12 11:08 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt7pav4q.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).