From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Add four new Modus themes to Emacs? Date: Mon, 19 Dec 2022 15:53:26 +0000 Message-ID: <87mt7j5r0p.fsf@posteo.net> References: <871qow6ixb.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3728"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Protesilaos Stavrou Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 19 16:54:31 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7ITG-0000n1-Lf for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Dec 2022 16:54:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7ISI-0007v8-KM; Mon, 19 Dec 2022 10:53:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7ISF-0007s4-DM for emacs-devel@gnu.org; Mon, 19 Dec 2022 10:53:27 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7ISD-0000qu-HZ for emacs-devel@gnu.org; Mon, 19 Dec 2022 10:53:27 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id BA50024002B for ; Mon, 19 Dec 2022 16:53:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671465202; bh=GXTeMlnprmkQzCDcoR32d+jjFK/iVQvXjOeaETyIJEQ=; h=From:To:Cc:Subject:Date:From; b=H7lE7/tirFhtch9VjKMGINO7iZophu4/UlCoc28fVwkEhqqat9VPWnbwWwIjTabOj Hq+dKOyuxr6ak7cVdDOGjQv8IN5v9Y6KJImop9r9VtIvcUCNFkabRYLyTIywf/Kl64 mRkGyVuF5Z+/gOpwnT7czGfNTPWpPdn/vXbQGoUBxvMGj0woUnoin7MUFV+BPqEmLs fgzmHpmiB17S9WXMJJxigUH8yrXIoI4ApfeszUjDpCUXQINrhrcf1BXenbLudivI3J DWysQ9NQQ6lto0+Cjt8108uaRjQkp+VbsTwy58OECfwpnEBhZ7TyXbGW9AjDGH6Ynj /yPXS4aYxoU3Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NbPPZ1NbRz6tmv; Mon, 19 Dec 2022 16:53:22 +0100 (CET) In-Reply-To: <871qow6ixb.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Mon, 19 Dec 2022 07:50:40 +0200") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301651 Archived-At: Protesilaos Stavrou writes: > Hello everyone, Hi, > I am developing version-4 of the modus-themes. Part of this endeavour > is the creation of four new themes. Originally, we had 'modus-operandi' > (light theme) and 'modus-vivendi' (dark theme). They are the ones that > are shipped with Emacs since version 28. > > The new themes: [...] > All new themes are consistent with the WCAG AAA accessibility standard > for colour contrast. > > Should these four new themes be added to emacs.git when I release > version-4? Or should I just update only 'modus-operandi' and > 'modus-vivendi'? My main worry is that the default theme options could get too crowded. Then again, if we want to keep deuteranopia support, the two new variants will have to be added... (On that topic, I still think that the approach I suggested earlier this year would be preferable: Instead of a separate theme or multiple options, we just need to describe the transformations that maximise the volume of the original colour space within the boundaries of whatever is permissible for each kind of colour deficiency). The alternative is having the base themes in Emacs, and if anyone wants more then they would have to download the themes from ELPA, right? > My plan is to finalise version-4 by the end of this month. It contains > lots of changes. This might be a bit late, but I think that you were a bit too quick in deprecating a lot of the user option, while also dropping backwards compatibility. Usually, an option is deprecated and users are given hints what they have to do in the future, but everything will continue working for now. When I recently installed version-4, I noticed that a number of things changed and I wasn't sure where to look to fix these issues. Now of course, this is just a visual theme and nothing about Emacs breaks functionality-wise, but it would still be nice to have a shim for now that translates old user options into the new configuration pattern.