From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, mail@daniel-mendler.de, emacs-devel@gnu.org,
monnier@iro.umontreal.ca
Subject: Re: 29.0.60; keymap-local-set and keymap-global-set became less strict
Date: Tue, 31 Jan 2023 16:48:02 +0100 [thread overview]
Message-ID: <87mt5yogct.fsf@gmail.com> (raw)
In-Reply-To: <831qna3frm.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 31 Jan 2023 17:06:21 +0200")
>>>>> On Tue, 31 Jan 2023 17:06:21 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: Daniel Mendler <mail@daniel-mendler.de>, emacs-devel@gnu.org, Stefan
>> Monnier <monnier@iro.umontreal.ca>, Eli Zaretskii <eliz@gnu.org>
>> Date: Tue, 31 Jan 2023 10:05:15 +0100
>>
Lars> So keymap-local-set and keymap-global-set should be fixed to be strict
Lars> again, otherwise there's not much point to the entire `keymap-*'
Lars> exercise.
>>
>> OK. How about this then (why are the `cursor-in-echo-area' shenanigans
>> necessary? I wonder if thatʼs a bug, since without them we either get
>> the cursor not showing in the minibuffer for
>> `read-key-sequence-vector', or we get an extra space displayed by
>> `read-command')
Eli> Why does it have to be so complicated, though? If the problem is not
Eli> to call key-description in non-interactive invocations, can't we call
Eli> key-description inside the interactive form? Or use some other trick
Eli> to invoke key-description only in interactive calls?
? Weʼre only calling key-description inside `interactive' in the
patch.
Ideally Iʼd like to use a format string to `interactive', and
massage the results, but I donʼt think thatʼs possible (Iʼd love to be
wrong).
I guess we could use `called-interactively-p', but thatʼs frowned upon,
or add an optional `interactive' arg thatʼs set to `t' by the
`interactive' call, but that all feels messy.
Or we add a new interactive spec: 'Κ' that does the same as 'K' but
calls `key-description' (Iʼm joking)
Robert
--
next prev parent reply other threads:[~2023-01-31 15:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de>
[not found] ` <875ycngyji.fsf@gnus.org>
2023-01-31 9:05 ` 29.0.60; keymap-local-set and keymap-global-set became less strict Robert Pluim
2023-01-31 10:08 ` Stephen Berman
2023-01-31 14:27 ` [External] : " Drew Adams
2023-01-31 14:30 ` Stefan Monnier
2023-01-31 15:02 ` Robert Pluim
2023-01-31 15:06 ` Eli Zaretskii
2023-01-31 15:48 ` Robert Pluim [this message]
2023-01-31 16:37 ` Eli Zaretskii
2023-01-31 16:48 ` Robert Pluim
2023-01-31 18:43 ` Eli Zaretskii
2023-02-01 12:52 ` Robert Pluim
2023-02-01 13:06 ` Eli Zaretskii
2023-02-01 13:13 ` Daniel Mendler
2023-02-01 13:44 ` Robert Pluim
2023-02-01 14:11 ` Daniel Mendler
2023-02-01 13:50 ` Eli Zaretskii
2023-02-01 13:57 ` Daniel Mendler
2023-02-01 17:30 ` Eli Zaretskii
2023-02-01 18:20 ` Daniel Mendler
2023-02-01 18:54 ` Stefan Monnier
2023-02-01 20:22 ` Daniel Mendler
2023-02-01 22:42 ` Stefan Monnier
2023-02-01 22:56 ` Daniel Mendler
2023-02-02 6:58 ` Eli Zaretskii
2023-02-02 9:29 ` Daniel Mendler
2023-02-02 9:40 ` Robert Pluim
2023-02-02 10:17 ` Eli Zaretskii
2023-02-03 9:17 ` Robert Pluim
2023-02-03 9:56 ` Richard Stallman
2023-02-04 9:55 ` Daniel Mendler
2023-02-03 9:56 ` Richard Stallman
2023-02-03 12:11 ` Eli Zaretskii
2023-02-05 4:27 ` Richard Stallman
2023-02-05 7:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt5yogct.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).