From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: Merging feature/android Date: Fri, 17 Mar 2023 16:50:22 +0800 Message-ID: <87mt4b3goh.fsf@yahoo.com> References: <87edq7ztks.fsf.ref@yahoo.com> <87r0tr79oe.fsf@yahoo.com> <86jzzjmp9h.fsf@gnu.org> <87mt4f788u.fsf@yahoo.com> <83fsa7s3yz.fsf@gnu.org> <87edpq7tke.fsf@yahoo.com> <875yb27qe8.fsf@yahoo.com> <87ttym5vgj.fsf@yahoo.com> <87sfe540or.fsf@yahoo.com> <86bkkt3wpb.fsf@gnu.org> <837cvhq8m3.fsf@gnu.org> <864jqkzz3p.fsf@gnu.org> <835yb0rjel.fsf@gnu.org> <86zg8cyjvq.fsf@gnu.org> <834jqkrdk6.fsf@gnu.org> <86pm98y66e.fsf@gnu.org> <83zg8cpj6h.fsf@gnu.org> <86a60bn4z1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36269"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , corwin@bru.st, emacs-devel@gnu.org To: Arash Esbati Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 17 09:51:42 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pd5oM-0009Bo-8L for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Mar 2023 09:51:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pd5nS-0002WQ-JC; Fri, 17 Mar 2023 04:50:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd5nP-0002W9-P2 for emacs-devel@gnu.org; Fri, 17 Mar 2023 04:50:43 -0400 Original-Received: from sonic316-22.consmr.mail.ne1.yahoo.com ([66.163.187.148]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pd5nO-0007un-3d for emacs-devel@gnu.org; Fri, 17 Mar 2023 04:50:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1679043032; bh=TO+pVk0o+gfXS+BxglZ+X1h3b6BnO21GsbvuIksFnHQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=uPAzz4Y8iqXoB0rhV1P//PI5PUlKVudJ26G8+/4K69WgqHt6GmbLtk8+d4hxLhwnNgpQpueQOhZI6epPIV4F4aV0WGI8B1WGl2XPT89RtJpocnqQB17LLFFNpU2UWsADbY2u3UWaBDHPoQfax/yAoQYMMfb0r5Ukuxh8RAXyW6Qz1CcJlPypuPLnNyDZ5mOb8jKMHmI9NNEz7rCBWC3gs/au5TXq7MqEIqjmhgXivvzM7rwXifql4TStb99PqTksc0U8LQJC1b5GQQFCdxOeCGiAGZr+nwShFxKwhS83gfA/sdC4oHzHyZDzNwppjvXNbfs+/Z0Yu6/+Od1uoxKvnA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1679043032; bh=l+VTuqvBOo/eEUVSuf9PlEbSJPVDm25TvWSNZPdb4Te=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=LDbFw9fsc6yOsBe+lAfbg8LmklqdtvmXTs/UGk0GUnb46eZdk89q7YW1moTZcLhyOf0RID7fBz7A/s5wrMErhSdjOWPGv6w9tjpVv/xOF+Ca2UMaFA3q5mjUdMfyB2ixl7QXbUqLXbdj0TFEw6moKBGjzip75Y36AxqFLFJvwR1rTndiHkcIUx6MWYS7qyCS544GABdY/BALoirgKHQfTDUtAYVBYx1MrO/oCEYlMHTgG12+OY2zR1S2VkQaoCt9pLP/0tFahIxWHvrSP2y+gw7WDOXPCrlseiXwh8oBM11LcP2DunZhs0MfFmsGH4UEOMpb4PQaxbzG5ukLThyIxw== X-YMail-OSG: rGvqBT4VM1mz2dhMgN6JuNGy9JAosxHZN7YIAInHQscx0CQBcGpjjHZXxTjQwL9 .ntn.L1_48wtQOp3gedGE2x2poAgn5Wz.7783DlrhHQdOl5tbHvynEKkMGr123ddOaDbT2MvcIbl AJKYBIAdeWft2DhAGFqY8EIR2EREZCYpRoXHipCNW0Hjx5fZZFnhtefe9hmeCUzNveYCmk27BVIt rCG4.s10ca27NKCNW5110sH_RL7_oh9gabOp8Cr_vrcLVol5YslR8nZngI8EjAtBOd_WOjSaAYLZ O3VwSA44bZawA5iCiLFiKxPpgf.G78uJJwNuFNCqv0d0v_OGA4LoCegSSpGH43raBoeuPbhxNo_V MQX.sCL9FaxwV50PPHM6RLgy9yapSb1xfMkzvaHS6fI7vS0MKHwIzQrCK4wZcyoWwNxzvqkiCjc1 .k1GnzQa0QXO_yQuiv6OHAnSbidFpBhRHAIYcq3aUQ8Q6KgeBmBLXbPcpXjK_O9yjpO9n2Dm1usY 4jLSl6.zW7h16JXo2rVEeDIy9k4DbigigXVfBw3j23HEiaj5xrRUcykDcZzVKpOUb26FFoeDaqO3 Jji44yJ4LtuHuTfZMSEkazk2JfzFx4usDVxY0bcZ4lMfxyszsYPkDTP.5gp_GNdMZpKAgb6tr3LD SAmJHmrE5EUweHtnPbvUOyNcAhVhhw_qoW0i6bofA8DwU4cVL3dgUTky6DJpkl4qms1XonMGXq1B d_7neDLsRfbDISPHonjS7pdwLVQcqjIDsvNbKoYyzwEfuSvwb6TApF7qeoWoGLYbMhluiEkFNrRr PoyM9vBqdtGfXUfnbeKPrCCmdK7Q392ye9ae_RCzP3 X-Sonic-MF: X-Sonic-ID: 58cfb007-08d4-4eb9-884d-f4c54bd01b74 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Fri, 17 Mar 2023 08:50:32 +0000 Original-Received: by hermes--production-sg3-67c57bccff-4xlmw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0d0aaea84f20b927931956073ddbc1ec; Fri, 17 Mar 2023 08:50:28 +0000 (UTC) In-Reply-To: <86a60bn4z1.fsf@gnu.org> (Arash Esbati's message of "Fri, 17 Mar 2023 09:42:58 +0100") X-Mailer: WebService/1.1.21311 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.187.148; envelope-from=luangruo@yahoo.com; helo=sonic316-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304540 Archived-At: Arash Esbati writes: > Eli Zaretskii writes: > >> That doesn't necessarily prove they are the same. Please compare the >> values of WARN_CFLAGS in src/Makefile between the two branches. > > Thanks. This is from master (line breaks added manually): > > WARN_CFLAGS = -fno-common -Wall -Warith-conversion -Wdate-time > -Wdisabled-optimization -Wdouble-promotion -Wduplicated-cond -Wextra > -Wformat-signedness -Winit-self -Winvalid-pch -Wlogical-op > -Wmissing-declarations -Wmissing-include-dirs -Wmissing-prototypes > -Wnested-externs -Wnull-dereference -Wold-style-definition -Wopenmp-simd > -Wpacked -Wpointer-arith -Wstrict-prototypes > -Wsuggest-attribute=noreturn -Wsuggest-final-methods > -Wsuggest-final-types -Wtrampolines -Wuninitialized -Wunknown-pragmas > -Wunused-macros -Wvariadic-macros -Wvector-operation-performance > -Wwrite-strings -Warray-bounds=2 -Wattribute-alias=2 -Wformat=2 > -Wformat-truncation=2 -Wimplicit-fallthrough=5 -Wshift-overflow=2 > -Wuse-after-free=3 -Wvla-larger-than=4031 > -Wno-missing-field-initializers -Wno-override-init -Wno-sign-compare > -Wno-type-limits -Wno-unused-parameter -Wno-format-nonliteral > -Wno-bidi-chars -Wno-pointer-sign > > This is from feature/android: > > WARN_CFLAGS = That's odd, I will look into this. Thanks. > And while looking at the diff: > > master uses the -isystem flag, feature branch uses -I, e.g.: > > WEBP_CFLAGS= -isystem C:/msys64/mingw64/include/webp (master) > WEBP_CFLAGS= -IC:/msys64/mingw64/include/webp (feature/android) > > Best, Arash I don't understand this change, since the configury used outside Android didn't change.