From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Option for sorting package-selected-packages Date: Sun, 26 Mar 2023 10:24:47 +0000 Message-ID: <87mt3z3j4g.fsf@posteo.net> References: <87a600mmdy.fsf@ya.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26142"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Ivan Sokolov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 26 12:25:44 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgNZI-0006VK-BP for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Mar 2023 12:25:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgNYX-0002J0-Ue; Sun, 26 Mar 2023 06:24:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgNYV-0002HD-Ia for emacs-devel@gnu.org; Sun, 26 Mar 2023 06:24:55 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgNYT-0007uu-HS for emacs-devel@gnu.org; Sun, 26 Mar 2023 06:24:55 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 2254E240267 for ; Sun, 26 Mar 2023 12:24:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679826290; bh=EloW7B9qbUBu35/sTP+6Q9cSdqVAlvvZDeXgT/CYkjs=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=d/dAMKFaERkW9uzMqOfkrbm2Flv02dVYSEs/0oj9s0k8c1aC++qjhfRFUwzYaJHZj J88bL6IEkX+QvK2tTpKWkAkH4wSHekIn8UP0Z4vFUFUVggOTeGHnG5Hp+O7eWJYcJz yrp5w+CAHtsB+/HiI/c04GCg/MI+R52Dcl5hakgFbBlEs/PkCyt6pOCsEVz+pcCL2p EXiAnV/nsv1+UTa5eLO6kWZS/JROy3UeElxjgMi3E8xNXiVfeBwXITEbVDcJbl9jZV Q2AaeiE9mGuAahD1PYFGtXXQe9b+VQ3nIkGX6JMQImEjx6M/pUKmcOYLPleTUDK+Xt DPr9xmQSmjhDA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PksWj1HLrz9rxM; Sun, 26 Mar 2023 12:24:49 +0200 (CEST) In-Reply-To: <87a600mmdy.fsf@ya.ru> (Ivan Sokolov's message of "Sun, 26 Mar 2023 02:39:21 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304773 Archived-At: Ivan Sokolov writes: > Nowadays many people keep their configuration under a VCS. I think this > new option might help them get tidier diffs and avoid merge conflicts. > > It might make sense to enable this option by default. > > From eb996ddc331e34a1c97331768420b9c6dfd30c15 Mon Sep 17 00:00:00 2001 > From: Ivan Sokolov > Date: Fri, 24 Mar 2023 23:27:13 +0300 > Subject: [PATCH] New option for sorting package-selected-packages > > * lisp/emacs-lisp/package.el (package-sort-selected-packages): New defcustom. > --- > lisp/emacs-lisp/package.el | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index 0258ed52bee..1e11be4ab3b 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -404,6 +404,13 @@ a sane initial value." > :version "25.1" > :type '(repeat symbol)) > > +(defcustom package-sort-selected-packages nil > + "If non-nil interactive functions will sort `package-selected-packages'. > +You can use this variable to get a nicer diffs if you keep your > +`custom-file' under version control system." > + :version "30.1" > + :type 'boolean) > > (defcustom package-native-compile nil > "Non-nil means to natively compile packages as part of their installation. > This controls ahead-of-time compilation of packages when they are > @@ -1974,7 +1981,10 @@ Used to populate `package-selected-packages'." > (defun package--save-selected-packages (&optional value) > "Set and save `package-selected-packages' to VALUE." > (when value > - (setq package-selected-packages value)) > + (setq package-selected-packages > + (if package-sort-selected-packages > + (sort value #'string<) > + value))) Why not just always sort it? Or is there a use-case where keeping the "arbitrary" order is preferable? > (if after-init-time > (customize-save-variable 'package-selected-packages package-selected-packages) > (add-hook 'after-init-hook #'package--save-selected-packages))) -- Philip Kaludercic