From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon Date: Fri, 28 Jul 2023 09:24:58 +0200 Message-ID: <87mszglcqd.fsf@gmx.de> References: <877cqpsnct.fsf@trop.in> <20230727080325.4372-1-andrew@trop.in> <87wmyl1sn8.fsf@gmx.de> <831qgtmsnf.fsf@gnu.org> <875y65jt8o.fsf@gmx.de> <87bkfwr4mg.fsf@trop.in> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23164"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Andrew Tropin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 28 09:48:35 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPIDC-0005rG-Oc for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Jul 2023 09:48:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qPHqV-0004bV-Cg; Fri, 28 Jul 2023 03:25:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPHqT-0004bK-Ee for emacs-devel@gnu.org; Fri, 28 Jul 2023 03:25:05 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPHqR-0001q4-LG; Fri, 28 Jul 2023 03:25:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1690529099; x=1691133899; i=michael.albinus@gmx.de; bh=ZxZaaYKNqejyfzFTfWRrPhPhoPXQOfTTpGfG1l+RvGo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=IAQkatrCVe1c3xvz1JalmEWFyF1RJV8+IbhuMRSnurtsYvtXVWXPJ2H7REQGE1piEUx88Vw iFfLujEjkBI8ViE1S+s9A0PNkBoHOCKj4DuE/iRA6BoD/z1PDYdbxzEnYRKk12N7eNOyyUf5a 5UiFjalRuROW9kn4J3hAgUtfQe1GHSPICNtTM875E1f0m4s5BUIY1BRn68t+MiiDOLu+Emt8H JUCwT7ouALAJAc17r5Bga0cC/EjGMKdkysJmfKMMHYCK2uvF5dw/v9v13MbELtA4nCebCch3w pF+7rYnq0mJHge/6QRXGawKRN5+gp2/uc5hBz2nclvlUt/lA6O1Q== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.27]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1McH9i-1ptVva47Ei-00ce2j; Fri, 28 Jul 2023 09:24:59 +0200 In-Reply-To: <87bkfwr4mg.fsf@trop.in> (Andrew Tropin's message of "Fri, 28 Jul 2023 09:23:35 +0400") X-Provags-ID: V03:K1:0/mZ2QAP9+ZXKmdkwd7UFgdicQFjVet0nzupCuEpHlTSGr7aTnz AuS+h6juMHxl/g6tXT2tr1vBq/LZvc+zOcTkap0sdKeU41MvDzyyYjtbY62FK7A9oppbzKz n4CLpdYCrrixmX6F5L6X0CRtwijtBzbQDmzt82OcQ5G59oVc78TbPdVpml1ZFmsX8zYDbvT e/TDQFbYCB/ik+Fs1udlg== UI-OutboundReport: notjunk:1;M01:P0:/a4lIABDCag=;3P+5entLvA2SyezDPkiJ6RYY+Hm AJfCKXOPqMSeL/HInzwggxn6djwYTb1vhjp19wuMc26mTar8t/+a0lTIrqrFoVW1PVhBl/D6v jTrRK6kEop5h4LWSyIxmvtwQCTjxMa1yGmw/qX7euJEJxIre0KjZbjBJUs3PdXgbbHFRgtJfS dwglxOAjSv/J5eFwL5fOvJSscv1uD0gtmJIGljFSrLyIquDR2XMS9kuvzmZRS9VN4PznR1VxX l4iVs1r7QWxAEqq2K95z5NcvQW7GW1iOYRDFxrlFOA8MdzLc4SMv2rJyBtWiqmuzk+XDIp/Fn 50E4SX34B0Cj2u9HgywpTtLiseL8uwwoSV9HX7+sLh0tUvMQSNYL8GW5Wr1IwsO6wcJOdmipu XdjerCCyXq6v3z/pqMtfwfzBYq2Z/YvUcK6pcjTI58uzfsgCG1MaurfqaQVuLx4A+FqgL0Ksm dy7rA1laTtOs/Rsyh4N338x8vtAIPbXnSlGNeZGre/d8LmnMUOHERdDgw97rD0vUTGEZv90af NDBqaxOFWH29eul8rTtt/Emv/oV5xa/esZatqbLyFx1Os9WHUizl+Bjr2rjojQ3aWTNYdstHM 2sd6kVye/lqwWktmYgBBQPupK8u2MCIuyeTiKuE5/mFd2ErSVqZuwaeXtjt3juhLIkla0lMMa G08a+Npb8dvFQwaOQCWGyYdFsVypMP+IjuyQLfsbFC/sZzKle4pYCkUPF2ZxSL+DyuuGMHNI0 EnbS7X0WAsFf6BoN7vNHUm3DheX6jp8GbIJjDjXl1zGhGHXD13lcqcnfjmfa1X5J6EzzAlIR Received-SPF: pass client-ip=212.227.15.18; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308186 Archived-At: Andrew Tropin writes: Hi Andrew, >>>> Thanks. Eli, if you don't have further comments, I would push this to master. >>> >>> Please do, and thanks. >> >> Done as commit 42a911c61e67caa807750cd40887b729f09aaf52. > > Thank you! You're welcome. I've digged the documentation further, and it seems like we've overlooked, that XDG icon names are possible already, via the :image-path argument: (notifications-notify :title "I am playing music" :image-path "multimedia-player") So the patch wasn't necessary. I'm a little bit undecided, whether we shall revert it. Eli? Best regards, Michael.