From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Improve find-sibling-rules option type Date: Sun, 24 Sep 2023 08:34:19 +0000 Message-ID: <87msxcc6lw.fsf@posteo.net> References: <20230924010433.1770-1-hello@paulwrankin.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7899"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Paul W. Rankin" To: "Paul W. Rankin" via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 24 10:35:19 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkKaF-0001ph-0s for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Sep 2023 10:35:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkKZP-0007rK-Lp; Sun, 24 Sep 2023 04:34:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkKZN-0007r5-TY for emacs-devel@gnu.org; Sun, 24 Sep 2023 04:34:25 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkKZM-0001tX-0C for emacs-devel@gnu.org; Sun, 24 Sep 2023 04:34:25 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 19D49240101 for ; Sun, 24 Sep 2023 10:34:21 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RtfSD34bfz9s0Z; Sun, 24 Sep 2023 10:34:20 +0200 (CEST) In-Reply-To: <20230924010433.1770-1-hello@paulwrankin.com> (Paul W. Rankin's message of "Sun, 24 Sep 2023 11:03:27 +1000") X-Hashcash: 1:20:230924:hello@paulwrankin.com::wg3N/0D5CLXd6kRx:0gwq X-Hashcash: 1:20:230924:emacs-devel@gnu.org::BEzC42rrFfrXprWf:BzOP Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311014 Archived-At: "Paul W. Rankin" via "Emacs development discussions." writes: > * lisp/files.el (find-sibling-rules): use alist with tags for custom > type > --- > This is preferable than having to enter a sexp as a user option. > > > lisp/files.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/files.el b/lisp/files.el > index 9d76668..e7adccd 100644 > --- a/lisp/files.el > +++ b/lisp/files.el > @@ -7572,7 +7572,8 @@ files, you could say something like: > In this example, if you're in \"src/emacs/emacs-27/lisp/abbrev.el\", > and a \"src/emacs/emacs-28/lisp/abbrev.el\" file exists, it's now > defined as a sibling." > - :type 'sexp > + :type '(alist :key-type (string :tag "Match") ^ (elisp) Simple Types lists a type `regexp' that you could use here as well. > + :value-type (string :tag "Expansion")) > :version "29.1") > > (defun find-sibling-file (file) -- Philip Kaludercic