From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Emanuel Berg <incal@dataswamp.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [NonGNU ELPA] Package suggestion: yeetube
Date: Wed, 04 Oct 2023 15:27:30 +0200
Message-ID: <87mswyecvx.fsf@dataswamp.org>
References: <87ttr67rkt.fsf@thanosapollo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="24690"; mail-complaints-to="usenet@ciao.gmane.io"
User-Agent: Gnus/5.13 (Gnus v5.13)
To: emacs-devel@gnu.org
Cancel-Lock: sha1:1J3bEpfI8O3EJEY273uA0fGlnWM=
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 04 18:28:50 2023
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1qo4jy-0006Aa-4f
	for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Oct 2023 18:28:50 +0200
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1qo4jC-0004L2-T6; Wed, 04 Oct 2023 12:28:03 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ged-emacs-devel@m.gmane-mx.org>)
 id 1qo1ui-0008Kv-Hi
 for emacs-devel@gnu.org; Wed, 04 Oct 2023 09:27:44 -0400
Original-Received: from ciao.gmane.io ([116.202.254.214])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ged-emacs-devel@m.gmane-mx.org>)
 id 1qo1ug-0007TX-Gd
 for emacs-devel@gnu.org; Wed, 04 Oct 2023 09:27:44 -0400
Original-Received: from list by ciao.gmane.io with local (Exim 4.92)
 (envelope-from <ged-emacs-devel@m.gmane-mx.org>) id 1qo1uc-0000iE-ST
 for emacs-devel@gnu.org; Wed, 04 Oct 2023 15:27:38 +0200
X-Injected-Via-Gmane: http://gmane.org/
Mail-Followup-To: emacs-devel@gnu.org
Mail-Copies-To: never
Received-SPF: pass client-ip=116.202.254.214;
 envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io
X-Spam_score_int: -16
X-Spam_score: -1.7
X-Spam_bar: -
X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9,
 HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Mailman-Approved-At: Wed, 04 Oct 2023 12:28:02 -0400
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:311278
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/311278>

Thanos Apollo wrote:

> I've been trying to learn elisp and made this simple niche
> package, to watch & download youtube content via Emacs using
> only free software.
>
> Homepage: https://git.thanosapollo.com/yeetube/about/

Nice!

I did

  (checkdoc-current-buffer t)

and also byte compiled with this command

   $ emacs -Q \
           --batch \
           --eval "(setq load-path (append load-path (list \".\")))" \
           -f batch-byte-compile *.el

to discover the following stuff you can improve:

*** yeetube-buffer.el: checkdoc-current-buffer
yeetube-buffer.el:185: Arguments occur in the doc string out
of order

In yeetube-buffer-create:
yeetube-buffer.el:209:8: Warning: ‘backward-delete-char’ is
for interactive use only; use ‘delete-char’ instead.

In yeetube-download-videos:
yeetube.el:250:2: Warning: docstring has wrong usage of
unescaped single quotes (use \=' or different quoting such as
`...')

In end of data:
yeetube.el:275:9: Warning: the function
‘yeetube-change-download-audio-format’ is not known to
be defined.

yeetube.el:274:9: Warning: the function
‘yeetube-change-download-directory’ is not known to
be defined.

PS. If you are into automated downloading, check out these files

  https://dataswamp.org/~incal/conf/.zsh/dl
  https://dataswamp.org/~incal/conf/.zsh/yt-dlp
  https://dataswamp.org/~incal/#mpv

It doesn't have an interface tho like yours, it just
downloads bulk and then you remove stuff you don't like
from mpv.

GLHF!

-- 
underground experts united
https://dataswamp.org/~incal