From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jay Kamat Newsgroups: gmane.emacs.devel Subject: Re: NonGNU ELPA: Conditions for accepting a potential new package 'rmsbolt' ? Date: Tue, 27 Feb 2024 08:13:57 -0800 Message-ID: <87msrleuwd.fsf@eve> References: <87jzmsmecw.fsf@jeremybryant.net> <877cir8yap.fsf@posteo.net> <877ciqn8wg.fsf@jeremybryant.net> <87y1b6tkk1.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6934"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.13; emacs 28.2 Cc: Jeremy Bryant , "emacs-devel@gnu.org" , monnier@iro.umontreal.ca To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 27 17:39:57 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rf0Ul-0001VQ-CN for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Feb 2024 17:39:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rf0U0-0005Ub-CE; Tue, 27 Feb 2024 11:39:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf0HK-0008Fd-0c for emacs-devel@gnu.org; Tue, 27 Feb 2024 11:26:03 -0500 Original-Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rf0HI-0007Hj-8T for emacs-devel@gnu.org; Tue, 27 Feb 2024 11:26:01 -0500 Original-Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-29a5f100c1aso3105300a91.0 for ; Tue, 27 Feb 2024 08:25:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709051157; x=1709655957; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=hUy42WHoMgZi8Mq0lCHekLkgvGazhVD97VlIC5aBONk=; b=M0iGHBjNg+HmLzrcUiqinddpy41sfZf9e2NOP1j/KdhKIR1eTvrYkJieYkQqvKFPKe ak1ZD/vl6zjOXvowM05kfuhm1Mq6dUydp6J6g/7sTJJc1oVnBtaBWGp1mh7uzbZT3OEw cWxdDfbAYdn2f8WjeedFnUt0csXSdIaL5oo43FHRS60f42PuJRdkFXHgo1dY72Hw8MQ4 3iWSO8LiuKdOTTNBAMmLlabTVwpRNJxYc020nYVtGTec9WcTw8t6eiy+eXXol7rlSUnJ gKWD6ikXzN3dO6sVET6LN714Yb4p+wWCZEcc7C35SwOJXERAtmKoyUbr8pSsu81SzTtJ neTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709051157; x=1709655957; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hUy42WHoMgZi8Mq0lCHekLkgvGazhVD97VlIC5aBONk=; b=KoPpnKBKAPFu/NPsQd9yZHAYDmHMJNBJXhXik1ZsCVaFdfaMvBiZ+0v9x1iL2WaGqe R3SzGnxJzPYPMhuEDKCW4WPWe12gClXkiVBcQGVnkcubRGNF+kFN3sWdGRM1HABvaPG2 k7RFvfWFdesyG/+tUbirhxotNcRu+35rGum0GBOPYGRkcsQXErXlon9GoDhkaZcaJ0vM ZtswFLMFTmxfHXycZBL2JPYmkeSxip5BNwvGuk0eM+7gZK1jQC0mtyt3hIKEcptNyEYf JvuZpgUgM8QnhCWBdJWVgfOR2hDpBO8Exz6h/0GAbc+sMqidduvQ9F/RBv7c+YxL+k+N F6tA== X-Forwarded-Encrypted: i=1; AJvYcCVRaNwgnABQqY+t7OsLvjEot9Qn/OLvOI2RcVxsuxhxPjTqlY47OtniZxNo73RZ3IapiSeMBSdgxZ/XFdMKig+Sh8Jw X-Gm-Message-State: AOJu0Yxlw/1gA5xkch41d3anfnBoC/bz1btCxzsZPHzS16qb75bDgmRH 1W3Jmvplh0Db/+g0TWCxTrqJzki4XKDrJVjU/EcEmx+klB3MM6PU X-Google-Smtp-Source: AGHT+IGw6o/A9FdO1xJHkLYsM5naETQVDPbgO3QAC5Liq+JKSqSxydqlsPmuO0bdYm9XgLsrt9AFgg== X-Received: by 2002:a17:90a:688f:b0:299:6627:2fa2 with SMTP id a15-20020a17090a688f00b0029966272fa2mr6655232pjd.17.1709051157089; Tue, 27 Feb 2024 08:25:57 -0800 (PST) Original-Received: from eve (c-98-207-12-150.hsd1.ca.comcast.net. [98.207.12.150]) by smtp.gmail.com with ESMTPSA id pt11-20020a17090b3d0b00b0029a9ec5dd87sm6708961pjb.23.2024.02.27.08.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 08:25:56 -0800 (PST) In-reply-to: <87y1b6tkk1.fsf@posteo.net> Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=jaygkamat@gmail.com; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 27 Feb 2024 11:39:06 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316591 Archived-At: Philip Kaludercic writes: Might take me a while to fully review and test all the changes, but they lo= ok=20 good, so once I do so, I'll include them! > +(defcustom rmsbolt-mode-lighter " RMS=F0=9F=97=B2" ;could the unicode ch= arachter be=20 > removed? it can unnecessarily resize the mode line. Sure - I can remove it. I'll do it after I apply your patch generally. > -(defun rmsbolt--convert-file-name-to-system-type (file-name) > +(defun rmsbolt--convert-file-name-to-system-type (file-name) ;perhaps us= e=20 > `convert-standard-filename'? Right now, a contributor is trying to improve this area/enable tramp suppor= t -=20 so I'd like to keep this as stable as possible while they do so. But this i= s a=20 great suggestion - I'll let them know about this function and hopefully it= =20 will help them in their change as well! > -(defmacro rmsbolt--set-local (var val) > +(defmacro rmsbolt--set-local (var val) ;`setq-local' is avaliable from=20 > 24.3 onwards I'll make this change after I get this in, thanks! > - (cmd (mapconcat > + (cmd (mapconcat ;you have `string-join' in subr-x > #'identity > (list compiler "-g" "-output-s" src-filename "-of"=20 > output-filename) > " "))) Not sure why I missed this - I'll fix this after this patch as well - thank= s! > - (setq rmsbolt--temp-dir nil))))) > + (setq rmsbolt--temp-dir nil))))) ;why is this necessary= =20 > while killing emacs? This is mostly me being very paranoid - as this function could delete rando= m=20 directories if misconfigured/in error, I want to disable it as soon as=20 possible. > > ;;;;; Starter Definitions > > ;; IIUC, this "starter" business is not a necessary part of RMSBolt, but= is > ;; a way to provide sample files with which users can try out RMSBolt. > > -(defvar rmsbolt-starter-files > +(defvar rmsbolt-starter-files ;should this be part of a secondary=20 > file that isn't loaded by default? Maybe - I think I would load it by default though - as this is the easiest = way=20 for someone to try out the package. In my personal usage I almost always st= art=20 from one of these files and add my changes. I should update the comment abo= ve=20 with that information as well. Thanks! I just want to be doubly sure of all the changes before I commit th= em,=20 I'll try to do that testing tomorrow - I'm a bit busy today. I'll also try = to=20 fix any remaining checkdoc errors. -Jay