From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Helmut Eller Newsgroups: gmane.emacs.devel Subject: Re: MPS signals and Emacs Date: Tue, 23 Apr 2024 08:35:30 +0200 Message-ID: <87mspkk2ml.fsf@gmail.com> References: <878r16n5jl.fsf@gmail.com> <87ttjulb16.fsf@gmail.com> <86a5ll7wj9.fsf@gnu.org> <71431fc4-2ab2-4778-88df-25d4e315d737@cs.ucla.edu> <00fec231-a625-406e-a51b-cb66710c6482@cs.ucla.edu> <87le54g1h2.fsf@dick> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27196"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: dick , Paul Eggert , Eli Zaretskii , emacs-devel@gnu.org To: Gerd =?utf-8?Q?M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 23 08:36:30 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rz9lV-0006w9-BJ for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Apr 2024 08:36:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rz9kk-0003jG-Vs; Tue, 23 Apr 2024 02:35:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rz9kg-0003ia-P3 for emacs-devel@gnu.org; Tue, 23 Apr 2024 02:35:40 -0400 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rz9kc-00046m-He; Tue, 23 Apr 2024 02:35:37 -0400 Original-Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-41a5b68ed0aso12020925e9.2; Mon, 22 Apr 2024 23:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713854132; x=1714458932; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=lE4C5LWH0IKemKSPJYjnL3nXoYG3EHu9I7g81WpCGeg=; b=IkdRNg3PHr/FO4XjHT3hJW/eo1sNtPR/IImEb1eeO3UP2Pyv4xddpj6HnuR0Fpac4l Lysdm8RAKHOJ8hvJLPLcj/qQYiYx+dcad0ckd85u5ZAJoLe74M51lFj/bJkITGqZRF3T qgczrbtno4y8tKJjALf+Giyrot46snvaWSnFzKN14/KuE6pzPelnSDO1WHMZ5+Dj26VY rcmekzBTVWKogHZDNbiy0KiuxA1yQAMWvnnomVpZB93ptBzpv/EuX2VvpPrx4S235dgo lBa7qOKwb/M/l4Zx/xG6cTAMKpNB7S6ibAc9f3nNkvlXD7BRvcOVYocUCP9D65aC8Nkg OTKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713854132; x=1714458932; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lE4C5LWH0IKemKSPJYjnL3nXoYG3EHu9I7g81WpCGeg=; b=hShuDwsAqm5rqrlPcoIsPt8EAHYiWfxoaZJ/cdr7ufiYwtEIN8HuDUon8vUCTdGhUP YoRvjm3Al/Rs96KG6CMl20CR1wiOy9EJ9le8Rk4WvrEPYhVasj33RG+fkEwEcTAHiHyX AVAQSTrQC93R0thqmiwqHoekFq3KQVT1GLQ/7sLqikFr0mjgYYtK2vItn0p/is1VWyQx 7koC012bgAaUaMEXpnOw5gGbnNnqy1oPtkvB9MCrON3XEKCpewLB9eJO8EUdBUiVtOI/ R8dD6zIpRB+gb1enyjExlMcMr7YxcIBYn8kYkMAKty8J07H27zqj2H4JOegnyb2vTMsy NYGg== X-Forwarded-Encrypted: i=1; AJvYcCXCvzP/zn+XnaagA6EDAu7r+ytc4TayPGDv6fFxlDY3Y0Z1zBHMxOCknQnZD7hBcV4vSrUzffoNxWiZa44eJZg2p8T8WgUNt85p8eGW2EsYao0= X-Gm-Message-State: AOJu0YwnjRKMiPlnZvlJW8L0UF+szP3DAq0BQNmOViRCw570v+DycYUm ffwPhLXCIc8dG8h0il6ILbzzsat6y5PqMmCgAdINaAPSG4RREvjPSHwueg== X-Google-Smtp-Source: AGHT+IF+cSrcXw9H0zqjy7MIEOGgLM+N7UoIcLuWMkuZQIb46c9P/FkmxldcPjNJKGRTR3VAr7zcmQ== X-Received: by 2002:a05:600c:46c6:b0:418:25af:1ed7 with SMTP id q6-20020a05600c46c600b0041825af1ed7mr8516933wmo.14.1713854132077; Mon, 22 Apr 2024 23:35:32 -0700 (PDT) Original-Received: from caladan ([89.107.106.118]) by smtp.gmail.com with ESMTPSA id w14-20020adfee4e000000b00343d6c7240fsm13624609wro.35.2024.04.22.23.35.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 23:35:31 -0700 (PDT) In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llmann?= =?utf-8?Q?=22's?= message of "Tue, 23 Apr 2024 07:51:20 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=eller.helmut@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318000 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Apr 23 2024, Gerd M=C3=B6llmann wrote: > dick writes: > >> GM> Initially it was macOS only, but Helmut showed that it works on >> GM> Debian, too. >> >> The name "Helmut" sounds like a guy who smokes the good herb. It's a >> non-starter if MPS doesn't jive under x11 (which turns on >> HAVE_TEXT_CONVERSION). > > Thanks. Can't help with that though, I'm afraid, I'm not a Linux user, > never have been, privately. Feel like sending patches? The patch below would allow compilation with X. It starts and I don't see any obvious breakage. Maybe good enough to keep the kids quiet. Helmut --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Allow-compilation-with-X.patch >From 0c5683728fffef2e3a74c72f1ff9e7964b35e6ec Mon Sep 17 00:00:00 2001 From: Helmut Eller Date: Tue, 23 Apr 2024 08:23:04 +0200 Subject: [PATCH] Allow compilation with X. * src/igc: Turn the error about text conversion into a warning. (Figc_roots): Initialize the result. * src/gtkutil.c (xg_mark_data) * src/xselect.c (mark_xselect) * src/xterm.c (mark_xterm): Don't define marking functions when compiling with MPS. --- src/gtkutil.c | 2 ++ src/igc.c | 5 +++-- src/xselect.c | 2 ++ src/xterm.c | 2 ++ 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/gtkutil.c b/src/gtkutil.c index c067f7b53ac..a01b8a41d5d 100644 --- a/src/gtkutil.c +++ b/src/gtkutil.c @@ -3025,6 +3025,7 @@ unref_cl_data (xg_menu_cb_data *cl_data) /* Function that marks all lisp data during GC. */ +#ifndef HAVE_MPS void xg_mark_data (void) { @@ -3069,6 +3070,7 @@ xg_mark_data (void) } #endif } +#endif /* Callback called when a menu item is destroyed. Used to free data. W is the widget that is being destroyed (not used). diff --git a/src/igc.c b/src/igc.c index 680f1a5ccb6..8c250eb57e6 100644 --- a/src/igc.c +++ b/src/igc.c @@ -58,7 +58,8 @@ # error "HAVE_PDUMPER required" #endif #ifdef HAVE_TEXT_CONVERSION -# error "HAVE_TEXT_CONVERSION not supported" +//# error "HAVE_TEXT_CONVERSION not supported" +# warning "HAVE_TEXT_CONVERSION not supported" #endif /* Note: Emacs will call allocation functions whlle aborting. This leads @@ -2647,7 +2648,7 @@ DEFUN ("igc-roots", Figc_roots, Sigc_roots, 0, 0, 0, doc : /* */) (void) { struct igc *gc = global_igc; - Lisp_Object roots; + Lisp_Object roots = Qnil; for (igc_root_list *r = gc->roots; r; r = r->next) { diff --git a/src/xselect.c b/src/xselect.c index fd0f06eeed9..b93c2423f0e 100644 --- a/src/xselect.c +++ b/src/xselect.c @@ -3488,6 +3488,7 @@ syms_of_xselect_for_pdumper (void) property_change_reply = Fcons (Qnil, Qnil); } +#ifndef HAVE_MPS void mark_xselect (void) { @@ -3518,3 +3519,4 @@ mark_xselect (void) mark_object (cs->string); } } +#endif diff --git a/src/xterm.c b/src/xterm.c index e08ffd15b18..36f83a33244 100644 --- a/src/xterm.c +++ b/src/xterm.c @@ -32212,6 +32212,7 @@ init_xterm (void) #endif } +#ifndef HAVE_MPS void mark_xterm (void) { @@ -32263,6 +32264,7 @@ mark_xterm (void) } #endif } +#endif /* Error handling functions for Lisp functions that expose X protocol requests. They are mostly like `x_catch_errors' and friends, but -- 2.39.2 --=-=-=--