From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point) Date: Mon, 29 Apr 2024 18:14:44 +0000 Message-ID: <87mspcave3.fsf@localhost> References: <87leba3ame.fsf@localhost> <88435424-afa3-d7a3-56ff-df9f0a2ca6ba@gmail.com> <875xz39cgp.fsf@localhost> <87ttk6da89.fsf@localhost> <673a0f71-c91f-8461-7388-9efbed6ba24f@gmail.com> <0c66ae28-7088-3ac7-be39-7714b8f80455@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36894"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eliz@gnu.org, emacs-devel@gnu.org, emacs-orgmode@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 29 20:14:35 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s1VWN-0009Mw-0C for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Apr 2024 20:14:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1VVe-0000FY-VG; Mon, 29 Apr 2024 14:13:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1VVe-0000FI-1d for emacs-devel@gnu.org; Mon, 29 Apr 2024 14:13:50 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1VVZ-0002Im-1w for emacs-devel@gnu.org; Mon, 29 Apr 2024 14:13:49 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3DD6F240106 for ; Mon, 29 Apr 2024 20:13:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1714414423; bh=a/CG/lKknd+sMD8jEIHLVhglzo+szyZ4Inl6SN4OdbE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=Yh4yVuR64uwU7AnvSjUMbHwtMlWvIRCnYk7ojbr/9u8yIltReS/gaozOzdqpJnGeb +jDRyTe7a3PfaJ2wx+HINTNHYwirmzhGEqZ2zKMVre/Rv+zTTCGco3J7LxiBlYymQ/ wZqtPkAAMMj4M0OYI14/wyjE194HQxsKD/TW3VJ0IJb8OSYDH5gUwPk08tnyh5MMuM A+Knf5q/POlAObJ25/h5yaq5FKyCcrKAQ/1UlAKIanN1ZUPB/Vgq5OAMmC4p1j5IC8 5FSd/jWIfkzYkLec/QwFHuNuMItomx5m0XvqiSex8Dc4khgXGL0/X47pba844x81dX mIYs3t5rOKgUQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VSs062cb1z6tsb; Mon, 29 Apr 2024 20:13:42 +0200 (CEST) In-Reply-To: <0c66ae28-7088-3ac7-be39-7714b8f80455@gmail.com> Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318371 gmane.emacs.orgmode:161334 Archived-At: Jim Porter writes: > Ihor, Eli: What do you think of the attached patch? I added variables to > let modes define custom providers for 'bounds-of-thing-at-point' and > 'forward-thing'. (Notably, I avoided adding vars for the > 'beginning-of-thing' and 'end-of-thing' functions, since those just call > 'bounds-of-thing-at-point' anyway.) > > If this looks like a reasonable way to go, I'll continue work on this > patch by adding entries to 'bounds-of-thing-at-point-provider-alist' and > 'forward-thing-provider-alist' in the appropriate places (i.e. wherever > we already add to 'thing-at-point-provider-alist', like in EWW). Thanks! I have a small comment on the docstring of `forward-thing-provider-alist' - it refers to `thing-at-point-provider-alist', but the provides here are called with an argument N, unlike the providers in `thing-at-point-provider-alist'. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at