From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Rob Browning Newsgroups: gmane.emacs.devel Subject: Re: Building emacs with and without X -- packaging question. Date: Tue, 17 Sep 2002 10:32:20 -0500 Sender: emacs-devel-admin@gnu.org Message-ID: <87lm60iqd7.fsf@raven.i.defaultvalue.org> References: <87adppy67u.fsf@raven.i.defaultvalue.org> <3405-Fri21Jun2002183331+0300-eliz@is.elta.co.il> <871yaz2tf8.fsf@raven.i.defaultvalue.org> <87k7nbacm7.fsf@raven.i.defaultvalue.org> <200208020611.g726BkU01069@aztec.santafe.edu> <877kj96z74.fsf@raven.i.defaultvalue.org> <200208040252.g742qam02724@aztec.santafe.edu> <873cscw9uq.fsf@raven.i.defaultvalue.org> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1032276827 17791 127.0.0.1 (17 Sep 2002 15:33:47 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 17 Sep 2002 15:33:47 +0000 (UTC) Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17rKMC-0004cW-00 for ; Tue, 17 Sep 2002 17:33:44 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17rL04-00058m-00 for ; Tue, 17 Sep 2002 18:14:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 17rKMV-0004xW-00; Tue, 17 Sep 2002 11:34:03 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 17rKKv-0004CI-00 for emacs-devel@gnu.org; Tue, 17 Sep 2002 11:32:25 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 17rKKr-000455-00 for emacs-devel@gnu.org; Tue, 17 Sep 2002 11:32:24 -0400 Original-Received: from n66644228.ipcdsl.net ([66.64.4.228] helo=defaultvalue.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 17rKKr-00042v-00 for emacs-devel@gnu.org; Tue, 17 Sep 2002 11:32:21 -0400 Original-Received: from raven.i.defaultvalue.org (raven.i.defaultvalue.org [192.168.1.7]) by defaultvalue.org (Postfix) with ESMTP id B0E841EF1 for ; Tue, 17 Sep 2002 10:32:20 -0500 (CDT) Original-Received: by raven.i.defaultvalue.org (Postfix, from userid 1000) id 787C35DD; Tue, 17 Sep 2002 10:32:20 -0500 (CDT) Original-To: emacs-devel@gnu.org In-Reply-To: <873cscw9uq.fsf@raven.i.defaultvalue.org> (Rob Browning's message of "Sat, 14 Sep 2002 16:16:13 -0500") Original-Lines: 53 User-Agent: Gnus/5.090006 (Oort Gnus v0.06) Emacs/21.2 (i386-pc-linux-gnu) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:7969 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:7969 Rob Browning writes: > I finally had time to work on this, and I think I've tracked it down. > In cus-dep.el we have: > > (let ((expr (read (current-buffer)))) > (condition-case nil > (progn > (eval expr) > (put (nth 1 expr) 'custom-autoloaded is-autoloaded) > (put (nth 1 expr) 'custom-where name)) > (error nil)))) > > Note that the condition-case ignores errors. With RMS's help, I've tracked down and fixed the scroll-bar.el related diff and one other so that fns-*.el is now the only significant difference between X and no-X versions of emacs. Two remaining questions: 1) would it be better if cus-dep's code didn't hide the errors while eval'ing the defcustoms above? i.e. should it at least print an error message (or perhaps even halt)? That would have caught both the defcusom errors I found (I believe the only two). 2) to fix the problem with gnus-art.el's gnus-article-x-face-command, I copy-pasted the code that initializes gnus-article-compface-xbm from gnus-ems.el. Can anyone see a problem with that as a short-term solution? (The diff is below.) Thanks --- 0/lisp/gnus/gnus-art.el 2002-03-22 11:03:55.000000000 -0600 +++ 1/lisp/gnus/gnus-art.el 2002-09-15 16:42:46.000000000 -0500 @@ -207,7 +207,8 @@ (if (and (fboundp 'image-type-available-p) (image-type-available-p 'xbm)) 'gnus-article-display-xface - (if gnus-article-compface-xbm + (if (eq 0 (string-match "#define" + (shell-command-to-string "uncompface -X"))) "{ echo '/* Width=48, Height=48 */'; uncompface; } | display -" "{ echo '/* Width=48, Height=48 */'; uncompface; } | icontopbm | \ display -")) -- Rob Browning rlb @defaultvalue.org, @linuxdevel.com, and @debian.org Previously @cs.utexas.edu GPG=1C58 8B2C FB5E 3F64 EA5C 64AE 78FE E5FE F0CB A0AD