MAIL_USE_FLOCK and Debian.

[Rob Browning <rlb@defaultvalue.org>]

On a Debian system, the setting of MAIL_USE_FLOCK in s/gnu-linux.h is
guaranteed to be wrong, so right now, Debian applies the patch below
and adds -DDEBIAN to CFLAGS in debian/rules.  Of course this fix isn't
appropriately general because it only works for people using
debian/rules to build Emacs packages.  So I'd like to figure out what
the "right" way to fix it would be.  The general rule is that on a
Debian system, you should only use liblockfile, nothing else.

Though I have patches that make sure that liblockfile is used and that
the location of the mail spool is detected correctly, we still need an
acceptable way to make sure that on a Debian system, MAIL_USE_FLOCK
isn't defined.

My patches also add support for dynamic detection and use of
USE_MAIL_SPOOL_DIRECTORY, CONF_MAIL_SPOOL_DIRECTORY,
CONF_MAIL_PROGRAM_NAME, MOVEMAIL_LOCK_LIBS, and the elisp-side
mail-spool-directory variable, though I'm not sure those changes, as
they stand, will necessarily be wanted upstream.  I discussed them
with Gerd some time back, but now I need to finish re-evaluating them
against current CVS, and to discuss them here to make sure they're
still desired.

Thanks

--- emacs21-21.2.orig/src/s/gnu-linux.h
+++ emacs21-21.2/src/s/gnu-linux.h
@@ -130,7 +130,14 @@
    programs.  I assume that most people are using newer mailers that
    have heard of flock.  Change this if you need to. */
 
-#define MAIL_USE_FLOCK
+/* On Debian/GNU/Linux systems, configure gets the right answers, and
+   that means *NOT* using flock.  Using flock is guaranteed to be the
+   wrong thing. See Debian Policy for details. */
+#ifdef DEBIAN
+#  undef MAIL_USE_FLOCK
+#else
+#  define MAIL_USE_FLOCK
+#endif

-- 
Rob Browning
rlb @defaultvalue.org, @linuxdevel.com, and @debian.org
Previously @cs.utexas.edu
GPG starting 2002-11-03 = 14DD 432F AE39 534D B592  F9A0 25C8 D377 8C7E 73A4