unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: Re: Insert character pairs
Date: Thu, 29 Apr 2004 14:00:32 +0300	[thread overview]
Message-ID: <87llkfoxpr.fsf@mail.jurta.org> (raw)
In-Reply-To: <jewu3zjdoa.fsf@sykes.suse.de> (Andreas Schwab's message of "Thu, 29 Apr 2004 12:12:21 +0200")

Andreas Schwab <schwab@suse.de> writes:
> Juri Linkov <juri@jurta.org> writes:
>>    (and parens-require-spaces
>>         (not (bobp))
>> -       (memq (char-syntax (preceding-char)) '(?w ?_ ?\) ))
>> +       (memq (char-syntax (preceding-char)) (list ?w ?_ close))
>
> This won't work, the list contains syntax codes, not characters.

Actually, it does work for parentheses arguments, so it is
still backward compatible.  But, of course, you are right that
it should be fixed, because it makes no sense for other characters
whose syntax character doesn't coincide with the character itself.

To fix it, it seems reasonable to check for character syntax of
arguments before inserting a space, i.e. insert a space
when character syntax of adjacent characters is the same,
(plus ?w and ?_, i.e. inside words as it was before):

-       (memq (char-syntax (preceding-char)) '(?w ?_ ?\) ))
+       (memq (char-syntax (preceding-char)) (list ?w ?_ (char-syntax close)))

-       (memq (char-syntax (following-char)) '(?w ?_ ?\( ))
+       (memq (char-syntax (following-char)) (list ?w ?_ (char-syntax open)))

-- 
Juri Linkov
http://www.jurta.org/emacs/

  reply	other threads:[~2004-04-29 11:00 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-29  8:48 Insert character pairs Juri Linkov
2004-04-29 10:12 ` Andreas Schwab
2004-04-29 11:00   ` Juri Linkov [this message]
2004-04-29 11:21     ` Andreas Schwab
2004-04-29 11:59       ` Juri Linkov
2004-04-29 14:24 ` Stefan Monnier
2004-04-29 15:02   ` Juri Linkov
2004-04-29 16:57     ` Stefan Monnier
2004-04-30  0:48       ` Juri Linkov
2004-04-30 13:43         ` Stefan Monnier
2004-04-30 23:22           ` Juri Linkov
2004-05-01  8:19 ` Juri Linkov
2004-05-02 16:19   ` Juri Linkov
2004-05-03 14:03     ` Richard Stallman
2004-05-04 15:57     ` Johan Bockgård
2004-05-04 16:48       ` Juri Linkov
2004-05-05 20:20       ` Richard Stallman
2004-05-06 13:14         ` Juri Linkov
2004-05-06 17:19           ` Stefan Monnier
2004-05-08 21:43             ` Juri Linkov
2004-05-03 19:48   ` Kevin Rodgers
2004-05-04  5:51     ` Juri Linkov
2004-05-04 18:30       ` Kevin Rodgers
2004-05-04 19:32         ` Juri Linkov
2004-05-05 20:20           ` Richard Stallman
2004-05-06 12:02             ` Juri Linkov
2004-05-01 20:26 ` Stefan Monnier
2004-05-02 16:03   ` Juri Linkov
2004-05-02 16:41     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87llkfoxpr.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).