From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Marcelo Toledo Newsgroups: gmane.emacs.devel Subject: Re: syntax highlight fix for add-log.el Date: Sun, 03 Apr 2005 19:47:54 -0300 Message-ID: <87ll7zcw9x.fsf@kali.intranet> References: <87mzsgr4e3.fsf@kali.intranet> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1112638156 26451 80.91.229.2 (4 Apr 2005 18:09:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 4 Apr 2005 18:09:16 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 04 20:09:12 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DIVzI-0007ek-Lz for ged-emacs-devel@m.gmane.org; Mon, 04 Apr 2005 20:07:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DIVY2-0005jz-GD for ged-emacs-devel@m.gmane.org; Mon, 04 Apr 2005 13:39:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DITB1-0003KW-4h for emacs-devel@gnu.org; Mon, 04 Apr 2005 11:07:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DIT2U-0008Vh-2x for emacs-devel@gnu.org; Mon, 04 Apr 2005 10:58:56 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DISse-0004Tr-Ht for emacs-devel@gnu.org; Mon, 04 Apr 2005 10:48:44 -0400 Original-Received: from [200.246.179.113] (helo=hm13.locaweb.com.br) by monty-python.gnu.org with smtp (Exim 4.34) id 1DIEAt-0005l8-8e for emacs-devel@gnu.org; Sun, 03 Apr 2005 19:06:35 -0400 Original-Received: (qmail 28137 invoked from network); 3 Apr 2005 23:03:29 -0000 Original-Received: from unknown (10.1.10.10) by hm13.locaweb.com.br with QMTP; 3 Apr 2005 23:03:29 -0000 Original-Received: (qmail 12566 invoked from network); 3 Apr 2005 23:05:14 -0000 Original-Received: from unknown (HELO kali.intranet.marcelotoledo.org) (marcelo@marcelotoledo.org@201.9.94.151) by hm10.locaweb.com.br with SMTP; 3 Apr 2005 23:05:14 -0000 Original-To: emacs-devel@gnu.org Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEUREBKVenaCZF94VlBp TEhXPzzH0uJJMS+5w9gzIiKEqtMzAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEgAACxIB0t1+/AAA AAd0SU1FB9MGCwAYJycum7IAAAH+SURBVHjavVO5bttAECUCGMGWOwICtTtL5Si1s4ThLuBRuEwk gfEPCCptwQHBUh3LRWiC2L/NLGNHqyNtCJDFPL735kyS//mIf8Z94q4BToirJDe9FxThJoYX4oqD F975Sxc/Nq33/vx/kQzr0lZVfUHxa4Na26o+A8TPghCRys0ZZdgYRECylTsDVoRKgaasPVUaC6OU VKz14E5KGRiQUuq6aWMtEQCOQ72mVsQmbqjKfC6BU749YYhmbNashWmZPbqvEcPniBynuirbIYu0 RtRkkLCydP8rjxgvtMk1EaDRVa8jk5esYiDj8jF7AhcBlsDmtpiAiPE4EBoys5xrsc/pEfjSk0a9 BOIqF/3iCNCzQTlTklOWdv/pCHyz3CoA0AykT3dHYH/LrQKjtJGg48a/mwCUQAhpEwE3C84HlZyR AV3Hg6KcDTgnWPJM4r7vC+Bcu0MA1jEgeim57aEQvToZ+w0bsAmPXRdtPPX3y8ldKm3pgSf3F3N5 KFsB75a5c7wF7u04egW8QBwnzHjx3ygiGZUKnUJjIPXJtKhMY64g/AMg6Kr+cYBXCydW3GCWCp8y nXeHcHguHN8+rDuGzCDV3bybnINaH1QgLCqg6rouxFkocaPiQwhxNvq8YyAkxqfpfNh3fuZM+bjb 7kJmju/Yie+v/x+k/LDddr8BShKMrI4evB8AAAAASUVORK5CYII= User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.4 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:35549 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:35549 Richard Stallman writes: > ;; File names. > ! ("^\\(?: \\{8\\}\\|\t\\)\\* \\([^ ,:([\n]+\\)" > > This seems to insist on 8 spaces. > It can be any number of spaces; one space is enough. Modified to work with 1 or more spaces. > (log-edit-previous-comment arg) > ! (indent-region (point-min) (point-max) nil) > > This change looks like a no-op. What is the bug you intend to fix? I was looking old code and old documentation where column was no optional, sorry. Just ignore it. I've installed this patch: Index: lisp/ChangeLog =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/ChangeLog,v retrieving revision 1.7247 diff -u -r1.7247 ChangeLog --- lisp/ChangeLog 3 Apr 2005 21:26:11 -0000 1.7247 +++ lisp/ChangeLog 3 Apr 2005 22:44:25 -0000 @@ -1,3 +1,11 @@ +2005-04-03 Marcelo Toledo + + * add-log.el (change-log-font-lock-keywords): The manual + describing a Change Log entry, says: (...) "Aside from these + header lines, every line in the change log starts with a space or + a tab.". The font-lock was not highlighting lines started with + spaces, added support for it. + 2005-04-03 Roland Winkler * textmodes/bibtex.el (bibtex-url): Use format to generate the url. Index: lisp/add-log.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/add-log.el,v retrieving revision 1.156 diff -u -r1.156 add-log.el --- lisp/add-log.el 21 Mar 2005 14:37:35 -0000 1.156 +++ lisp/add-log.el 3 Apr 2005 22:44:33 -0000 @@ -225,7 +225,7 @@ (2 'change-log-email-face))) ;; ;; File names. - ("^\t\\* \\([^ ,:([\n]+\\)" + ("^\\(?: +\\|\t\\)\\* \\([^ ,:([\n]+\\)" (1 'change-log-file-face) ;; Possibly further names in a list: ("\\=, \\([^ ,:([\n]+\\)" nil nil (1 'change-log-file-face)) -- Marcelo Toledo marcelo@marcelotoledo.org http://www.marcelotoledo.org Mobile: 55 71 9116-1101