From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [rant] Should reverting a buffer really discard undo history? Date: Wed, 01 Jun 2005 19:31:56 -0400 Message-ID: <87ll5tpsh9.fsf-monnier+emacs@gnu.org> References: <87ll5w5vxa.fsf@wigwam.deepwood.net> <874qck8ky7.fsf-monnier+emacs@gnu.org> <200506012319.j51NJk3i012173@amrm2.ics.uci.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1117669020 717 80.91.229.2 (1 Jun 2005 23:37:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 1 Jun 2005 23:37:00 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 02 01:36:59 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Ddcl6-000182-Gu for ged-emacs-devel@m.gmane.org; Thu, 02 Jun 2005 01:36:25 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DdcqU-0000VX-8Z for ged-emacs-devel@m.gmane.org; Wed, 01 Jun 2005 19:41:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DdcpS-0000D8-Gr for emacs-devel@gnu.org; Wed, 01 Jun 2005 19:40:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DdcpP-0000Bl-VY for emacs-devel@gnu.org; Wed, 01 Jun 2005 19:40:52 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DdcpP-00008y-IH for emacs-devel@gnu.org; Wed, 01 Jun 2005 19:40:51 -0400 Original-Received: from [209.226.175.4] (helo=tomts16-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Ddciy-0006xZ-25 for emacs-devel@gnu.org; Wed, 01 Jun 2005 19:34:12 -0400 Original-Received: from alfajor ([67.71.32.43]) by tomts16-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20050601233202.EWTR27508.tomts16-srv.bellnexxia.net@alfajor>; Wed, 1 Jun 2005 19:32:02 -0400 Original-Received: by alfajor (Postfix, from userid 1000) id E710FD7339; Wed, 1 Jun 2005 19:31:56 -0400 (EDT) Original-To: Dan Nicolaescu In-Reply-To: <200506012319.j51NJk3i012173@amrm2.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 1 Jun 2005 16:19:46 -0700") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:38023 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:38023 > Maybe other users have a different experience, but for me 99% of the > time I would like undo info after a revert is when revert was invoked > by VC/pcl-cvs after a commit. > So from this users point of view if VC/pcl-cvs were not to revert the > buffer, saving undo after revert would not be missed much. Indeed, it may also be useful to allow the revert-undoability to be specified on a revert-by-revert basis. And VC/PCL-CVS would be well served by a "revert carefully" which would do something like "diff+patch" rather than an actual revert. Note that revert already does a limited form of diff+patch since it checks the prefix&suffix of the file/buffer which hasn't changed, so if only one line was changed the undo would record only a one-line change rather than a complete delete+insert of the whole buffer. Stefan