From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Tool-bar buttons unresponsive with tooltips on Date: Sat, 15 Oct 2005 10:15:42 -0400 Message-ID: <87ll0ueui9.fsf@stupidchicken.com> References: <8764rzx2rp.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1129385805 10273 80.91.229.2 (15 Oct 2005 14:16:45 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 15 Oct 2005 14:16:45 +0000 (UTC) Cc: storm@cua.dk Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 15 16:16:41 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EQmpI-0004Fq-3e for ged-emacs-devel@m.gmane.org; Sat, 15 Oct 2005 16:15:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EQmpH-0003ui-B8 for ged-emacs-devel@m.gmane.org; Sat, 15 Oct 2005 10:15:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EQmp7-0003uT-Vd for emacs-devel@gnu.org; Sat, 15 Oct 2005 10:15:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EQmp5-0003uG-27 for emacs-devel@gnu.org; Sat, 15 Oct 2005 10:15:45 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EQmp4-0003uD-V7 for emacs-devel@gnu.org; Sat, 15 Oct 2005 10:15:43 -0400 Original-Received: from [18.95.6.43] (helo=localhost.localdomain) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EQmp4-0002sX-VF for emacs-devel@gnu.org; Sat, 15 Oct 2005 10:15:43 -0400 Original-Received: by localhost.localdomain (Postfix, from userid 1000) id C1BA11E42D5; Sat, 15 Oct 2005 10:15:42 -0400 (EDT) Original-To: emacs-devel@gnu.org In-Reply-To: <8764rzx2rp.fsf@stupidchicken.com> (Chong Yidong's message of "Fri, 14 Oct 2005 16:27:38 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:44070 Archived-At: Chong Yidong writes: > With `emacs -q' and tool-bar-mode on: > > 1. Hover the mouse cursor over (e.g.) the "find file" icon > 2. Wait for the tool-tip to pops up. > 3. Click [mouse-1]. > > Result: the tool-tip is dismissed, but the button isn't clicked. You > have to click [mouse-1] a second time to launch find-file. > > Expected behavior: the [mouse-1] should not only dismisses the > tool-tip, but also click the button. This seems to be related to the remember_mouse_glyph changes made a few days ago. Reverting this change removes the problem: 2005-10-12 Kim F. Storm * xdisp.c (remember_mouse_glyph): New generic version based on glyph_rect and remember_mouse_glyph from xterm.c enhanced to properly handle all different window areas. * dispextern.h (remember_mouse_glyph): Add prototype. * xterm.c (glyph_rect, remember_mouse_glyph): Remove X versions. (note_mouse_movement, XTmouse_position): Use generic remember_mouse_glyph, add last_mouse_glyph arg. * w32term.c (note_mouse_movement): Fix last_mouse_glyph check. (glyph_rect, remember_mouse_glyph): Remove w32 specific versions. (note_mouse_movement, w32_mouse_position): Use generic remember_mouse_glyph, add last_mouse_glyph arg. * macterm.c (note_mouse_movement): Add call to remember_mouse_glyph. (glyph_rect, remember_mouse_glyph): Remove mac specific versions. (XTmouse_position): Adapt to use generic remember_mouse_glyph instead of pixel_to_glyph_coords. * window.c (coordinates_in_window): Fix x position for ON_RIGHT_MARGIN. Fix x position for ON_TEXT when left margin width > 0.