From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: follow-link not on mouse-face Date: Fri, 21 Oct 2005 14:59:29 +0300 Organization: JURTA Message-ID: <87ll0n11ey.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1129901089 25976 80.91.229.2 (21 Oct 2005 13:24:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 21 Oct 2005 13:24:49 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 21 15:24:40 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ESwpd-0005Vw-Tf for ged-emacs-devel@m.gmane.org; Fri, 21 Oct 2005 15:21:14 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ESwpd-0000WF-8p for ged-emacs-devel@m.gmane.org; Fri, 21 Oct 2005 09:21:13 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ESwQw-0006FY-GE for emacs-devel@gnu.org; Fri, 21 Oct 2005 08:55:42 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ESwQu-0006FH-Ob for emacs-devel@gnu.org; Fri, 21 Oct 2005 08:55:42 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ESwQf-00068z-SY for emacs-devel@gnu.org; Fri, 21 Oct 2005 08:55:26 -0400 Original-Received: from [194.126.101.114] (helo=mail.neti.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ESwQg-0007Iq-3d for emacs-devel@gnu.org; Fri, 21 Oct 2005 08:55:26 -0400 Original-Received: from mail.neti.ee (80-235-32-191-dsl.mus.estpak.ee [80.235.32.191]) by Relayhost1.neti.ee (Postfix) with ESMTP id 685461FB4 for ; Fri, 21 Oct 2005 15:55:38 +0300 (EEST) Original-To: emacs-devel@gnu.org User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:44498 Archived-At: I think it is a mistake to put the `follow-link' property on text areas that have no mouse-face=highlight. The `highlight' face is a good warning that mouse-1 click will try to follow links, and a missing `highlight' face indicates that it is always safe to click mouse-1 to relocate point. If these assumptions are true, then the correct way to put follow-link in *Occur* buffers is only on mouse-face properties like in the following patch: Index: lisp/replace.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/replace.el,v retrieving revision 1.225 diff -c -r1.225 replace.el *** lisp/replace.el 20 Oct 2005 16:53:10 -0000 1.225 --- lisp/replace.el 21 Oct 2005 11:57:59 -0000 *************** *** 694,699 **** --- 694,700 ---- (defvar occur-mode-map (let ((map (make-sparse-keymap))) (define-key map [mouse-2] 'occur-mode-mouse-goto) + (define-key map [follow-link] 'mouse-face) (define-key map "\C-c\C-c" 'occur-mode-goto-occurrence) (define-key map "\C-m" 'occur-mode-goto-occurrence) (define-key map "o" 'occur-mode-goto-occurrence-other-window) *************** *** 1157,1164 **** (insert "-------\n")) (add-text-properties beg end ! `(occur-target ,marker follow-link t ! help-echo "mouse-2: go to this occurrence"))))) (goto-char endpt)) (if endpt (progn --- 1158,1164 ---- (insert "-------\n")) (add-text-properties beg end ! `(occur-target ,marker help-echo "mouse-2: go to this occurrence"))))) (goto-char endpt)) (if endpt (progn -- Juri Linkov http://www.jurta.org/emacs/