From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Hrvoje Niksic Newsgroups: gmane.emacs.devel Subject: Re: Saving minibuffer history Date: Tue, 25 Oct 2005 11:20:15 +0200 Message-ID: <87ll0i7y28.fsf@xemacs.org> References: <87u0fkfc8c.fsf@xemacs.org> <873bn2s9cz.fsf@xemacs.org> <87zmp9sd0o.fsf-monnier+emacs@gnu.org> <87d5lunbsm.fsf@xemacs.org> <87acgy7e5k.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1130242846 11099 80.91.229.2 (25 Oct 2005 12:20:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 25 Oct 2005 12:20:46 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 25 14:20:39 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EUNkM-0007FW-UE for ged-emacs-devel@m.gmane.org; Tue, 25 Oct 2005 14:17:43 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EUNkF-0001p3-0S for ged-emacs-devel@m.gmane.org; Tue, 25 Oct 2005 08:17:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EULLK-00082s-CN for emacs-devel@gnu.org; Tue, 25 Oct 2005 05:43:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EULL2-00080P-OT for emacs-devel@gnu.org; Tue, 25 Oct 2005 05:43:39 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EUKyi-0006MC-5P for emacs-devel@gnu.org; Tue, 25 Oct 2005 05:20:22 -0400 Original-Received: from [195.29.150.97] (helo=ls405.htnet.hr) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EUKyh-0006uu-02 for emacs-devel@gnu.org; Tue, 25 Oct 2005 05:20:19 -0400 Original-Received: from ls422.t-com.hr (ls422.t-com.hr [195.29.150.237]) by ls405.htnet.hr (0.0.0/8.12.10) with ESMTP id j9P9KFWr026968; Tue, 25 Oct 2005 11:20:16 +0200 Original-Received: from ls422.t-com.hr (localhost.localdomain [127.0.0.1]) by ls422.t-com.hr (Qmlai) with ESMTP id 6E95C988047; Tue, 25 Oct 2005 11:20:16 +0200 (CEST) X-Envelope-Sender: hniksic@xemacs.org X-Envelope-Sender: hniksic@xemacs.org Original-Received: from ls422.t-com.hr (localhost.localdomain [127.0.0.1]) by ls422.t-com.hr (Qmlai) with ESMTP id 66B60988046; Tue, 25 Oct 2005 11:20:16 +0200 (CEST) Original-Received: from localhost.localdomain (83-131-15-239.adsl.net.t-com.hr [83.131.15.239]) by ls422.t-com.hr (Qmlai) with ESMTP id 147D78B80AC; Tue, 25 Oct 2005 11:20:16 +0200 (CEST) Original-Received: by localhost.localdomain (Postfix, from userid 1000) id 6D775380404; Tue, 25 Oct 2005 11:20:15 +0200 (CEST) Original-To: Stefan Monnier In-Reply-To: <87acgy7e5k.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 24 Oct 2005 18:24:07 -0400") User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.4 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:44803 Archived-At: Stefan Monnier writes: > Almost. There were a few comments missing, and things like that. You never informed me about those changes so I missed them. I did notice the changes in the patch you sent me. Please remember that this package is normally also maintained for XEmacs, and as an external package (although it probably doesn't have many external users). I also don't understand why you removed the "*" markers from the beginning of docstrings. Those variables *are* intended to be "set and modified by users". > E.g. please preserve the arch-tag. I don't know what it does and I don't use arch. Is it always the same? What purpose does it serve? > As mentioned earlier, your code truncates non-history variables as > well. But now that you use it to save the list of variables as > well, it means that if the number of history variables you have is > larger than savehist-length, than you will lose some of your history > as well. Fixed now, thanks.