From: Juri Linkov <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: Re: Index header in diff-mode
Date: Fri, 09 Dec 2005 11:55:07 +0200 [thread overview]
Message-ID: <87lkyupz5j.fsf@jurta.org> (raw)
In-Reply-To: <jwv8xuvh704.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 08 Dec 2005 11:46:48 -0500")
>> After saving them to files and visiting in diff-mode, sometimes I type
>> `C-c C-c' or `RET' on such index headers with the intention to visit the
>> first hunk. But instead, it visits the last hunk of the previous file
>> in the same multi-file diff. Wouldn't it be better to handle the index
>> header as part of the file header?
>
> I think you're right. Feel free to make this change,
I tried to add an optional Index regexp to diff-file-header-re:
(defconst diff-file-header-re
(concat
"^\\(Index: .+\n=+\n.+\n.+\n.+\n\\)?"
"\\(--- .+\n\\+\\+\\+ \\|\\*\\*\\* .+\n--- \\|[^-+!<>0-9@* ]\\).+\n"
(substring diff-hunk-header-re 1)))
but it works only in forward direction. When using M-P to go to the
beginning of the previous diff file, it doesn't set point at the
beginning of regexp's part inside `\\(Index...\\)?'. It sets point
after it. I understand this is how re-search-backward currently
works, but is there a way to make backward search more "greedy"?
The same problem also causes wrong lazy-highlighting in isearch.
E.g. after starting isearch at the beginning of:
abcabc
and typing `C-M-s a?b C-s C-r', "ab" is highlighted in lazy-highlight face,
but only "b" in isearch face.
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2005-12-09 9:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-08 7:44 Index header in diff-mode Juri Linkov
2005-12-08 16:46 ` Stefan Monnier
2005-12-09 9:55 ` Juri Linkov [this message]
2005-12-09 14:38 ` Stefan Monnier
2005-12-09 23:55 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lkyupz5j.fsf@jurta.org \
--to=juri@jurta.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).